Re: [RESEND PATCH v3 1/4] dt-bindings: connector: add power-opmode optional property to usb-connector

From: Rob Herring <robh@kernel.org>
To: Jun Li <lijun.kernel@gmail.com>
Cc: Amelie DELAUNAY <amelie.delaunay@st.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Russell King <linux@armlinux.org.uk>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
	Linux USB List <linux-usb@vger.kernel.org>,
	"moderated list:ARM/STM32 ARCHITECTURE" 
	<linux-stm32@st-md-mailman.stormreply.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Fabrice Gasnier <fabrice.gasnier@st.com>
Subject: Re: [RESEND PATCH v3 1/4] dt-bindings: connector: add power-opmode optional property to usb-connector
Date: Fri, 30 Oct 2020 09:32:23 -0500	[thread overview]
Message-ID: <CAL_JsqLbuNTnonH2SqcmF5YF_EB4gTQdS6L3yFKF9pJmaypdKg@mail.gmail.com> (raw)
In-Reply-To: <CAKgpwJVGUR9aSfoMkQ=ZXysgqn+H6n0uJbk5W9SeGiB7VXptwQ@mail.gmail.com>

On Thu, Oct 29, 2020 at 8:55 PM Jun Li <lijun.kernel@gmail.com> wrote:
>
> Amelie DELAUNAY <amelie.delaunay@st.com> 于2020年10月30日周五 上午12:52写道：
> >
> >
> >
> > On 10/29/20 4:40 PM, Rob Herring wrote:
> > > On Thu, Oct 29, 2020 at 10:58:03AM +0100, Amelie Delaunay wrote:
> > >> Power operation mode may depends on hardware design, so, add the optional
> > >> property power-opmode for usb-c connector to select the power operation
> > >> mode capability.
> > >>
> > >> Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
> > >> ---
> > >>   .../bindings/connector/usb-connector.yaml      | 18 ++++++++++++++++++
> > >>   1 file changed, 18 insertions(+)
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > >> index 728f82db073d..200d19c60fd5 100644
> > >> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > >> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> > >> @@ -93,6 +93,24 @@ properties:
> > >>         - device
> > >>         - dual
> > >>
> > >> +  power-opmode:
> > >
> > > I've acked this version:
> > >
> > > https://lore.kernel.org/r/20201020093627.256885-2-badhri@google.com
>
> That is a different property only for FRS.
>
> > >
> >
> > frs is used for Fast Role Swap defined in USB PD spec.
> > I understand it allows to get the same information but I'm wondering why
> > the property name is limited to -frs- in this case. What about a
> > non-power delivery USB-C connector ?
>
> It's only for FRS, FRS is in the scope of power delivery.
>
> >
> > Moreover, power-opmode property support is already merged in typec class:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/usb/typec/class.c?h=v5.10-rc1&id=12f3467b0d28369d3add7a0deb65fdac9b503c90
> > and stusb160x driver uses it :(
> >
> > So, do I need to modify stusb160x driver (and bindings) to take into
> > account this USB PD specific property?
>
> Only Type-C w/o PD need this "power-opmode" property, so this
> property is still required.

Yet we have the same set of values. So there's something common...

Rob