From: Rob Herring <robh@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] of/property: Introduce of_fwnode_name()
Date: Tue, 6 Nov 2018 12:13:30 -0600 [thread overview]
Message-ID: <CAL_JsqLdEciRtssX+x8TRmPX6QzZtNyMX9MrT9=J0DhhewFMZg@mail.gmail.com> (raw)
In-Reply-To: <20181106155347.GC10650@smile.fi.intel.com>
On Tue, Nov 6, 2018 at 9:53 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Nov 06, 2018 at 05:05:03PM +0200, Heikki Krogerus wrote:
>
> > Maybe it would be best to just read the "name" device property in
> > fwnode_name() and not have of_fwnode_name at all.
>
> If it's a mandatory property or somehow its presence is guaranteed, it would work.
It is currently, but after removing the name ptr, my current plan is
to remove the 'name' property too for FDT. On real OpenFirmware, it is
a real property so it will remain for sure in some cases.
Rob
next prev parent reply other threads:[~2018-11-06 18:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 9:17 [PATCH 0/4] device property: Add fwnode_name() helper Heikki Krogerus
2018-11-05 9:17 ` [PATCH 1/4] device property: Introduce fwnode_name() Heikki Krogerus
2018-11-05 14:37 ` Andy Shevchenko
2018-11-05 14:57 ` Heikki Krogerus
2018-11-05 9:17 ` [PATCH 2/4] ACPI: property: Introduce acpi_fwnode_name() Heikki Krogerus
2018-11-05 9:17 ` [PATCH 3/4] of/property: Introduce of_fwnode_name() Heikki Krogerus
2018-11-05 18:50 ` Rob Herring
2018-11-06 8:45 ` Heikki Krogerus
2018-11-06 10:58 ` Andy Shevchenko
2018-11-06 12:27 ` Heikki Krogerus
2018-11-06 13:18 ` Rob Herring
2018-11-06 14:28 ` Andy Shevchenko
2018-11-06 18:17 ` Rob Herring
2018-11-06 14:40 ` Heikki Krogerus
2018-11-06 14:55 ` Andy Shevchenko
2018-11-06 15:05 ` Heikki Krogerus
2018-11-06 15:53 ` Andy Shevchenko
2018-11-06 18:13 ` Rob Herring [this message]
2018-11-07 12:35 ` Heikki Krogerus
2018-11-05 9:17 ` [PATCH 4/4] device property: Drop get_named_child_node callback Heikki Krogerus
2018-11-05 14:38 ` [PATCH 0/4] device property: Add fwnode_name() helper Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLdEciRtssX+x8TRmPX6QzZtNyMX9MrT9=J0DhhewFMZg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).