From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752284AbdBIXQO (ORCPT ); Thu, 9 Feb 2017 18:16:14 -0500 Received: from mail.kernel.org ([198.145.29.136]:48456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbdBIXQM (ORCPT ); Thu, 9 Feb 2017 18:16:12 -0500 MIME-Version: 1.0 In-Reply-To: References: <20161023200355.GA5391@amd> <20161119232943.GF13965@valkosipuli.retiisi.org.uk> <20161214122451.GB27011@amd> <20161222100104.GA30917@amd> <20161222133938.GA30259@amd> <20161224152031.GA8420@amd> <20170203123508.GA10286@amd> <20170208213609.lnemfbzitee5iur2@rob-hp-laptop> <20170208223017.GA18807@amd> From: Rob Herring Date: Thu, 9 Feb 2017 17:03:03 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] devicetree: Add video bus switch To: Pavel Machek Cc: Sakari Ailus , "devicetree@vger.kernel.org" , Ivaylo Dimitrov , Sebastian Reichel , =?UTF-8?Q?Pali_Roh=C3=A1r?= , "linux-media@vger.kernel.org" , Kumar Gala , Mauro Carvalho Chehab , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 9, 2017 at 5:02 PM, Rob Herring wrote: > On Wed, Feb 8, 2017 at 4:30 PM, Pavel Machek wrote: >> On Wed 2017-02-08 15:36:09, Rob Herring wrote: >>> On Fri, Feb 03, 2017 at 01:35:08PM +0100, Pavel Machek wrote: >>> > >>> > N900 contains front and back camera, with a switch between the >>> > two. This adds support for the switch component, and it is now >>> > possible to select between front and back cameras during runtime. >>> > >>> > This adds documentation for the devicetree binding. >>> > >>> > Signed-off-by: Sebastian Reichel >>> > Signed-off-by: Ivaylo Dimitrov >>> > Signed-off-by: Pavel Machek >>> > >>> > >>> > diff --git a/Documentation/devicetree/bindings/media/video-bus-switch.txt b/Documentation/devicetree/bindings/media/video-bus-switch.txt >>> > new file mode 100644 >>> > index 0000000..1b9f8e0 >>> > --- /dev/null >>> > +++ b/Documentation/devicetree/bindings/media/video-bus-switch.txt >>> > @@ -0,0 +1,63 @@ >>> > +Video Bus Switch Binding >>> > +======================== >>> >>> I'd call it a mux rather than switch. >> >> It is a switch, not a multiplexor ( >> https://en.wikipedia.org/wiki/Multiplexing ). Only one camera can >> operate at a time. > > It's no different than an i2c mux. It's one at a time. > >> >>> BTW, there's a new mux-controller binding under review you might look >>> at. It would only be needed here if the mux ctrl also controls other >>> things. >> >> Do you have a pointer? > > Let me Google that for you: https://lwn.net/Articles/713971/ > >> >>> > +Required Port nodes >>> > +=================== >>> > + >>> > +More documentation on these bindings is available in >>> > +video-interfaces.txt in the same directory. >>> > + >>> > +reg : The interface: >>> > + 0 - port for image signal processor >>> > + 1 - port for first camera sensor >>> > + 2 - port for second camera sensor >>> >>> This could be used for display side as well. So describe these just as >>> inputs and outputs. >> >> I'd prefer not to confuse people. I guess that would be 0 -- output >> port, 1, 2 -- input ports... But this is media data, are you sure it >> is good idea to change this? > > And I'd prefer something that can be reused by others. > >> >> Pavel >> -- >> (english) http://www.livejournal.com/~pavelmachek >> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html