From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CEECC3A5A6 for ; Tue, 27 Aug 2019 12:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEA7821883 for ; Tue, 27 Aug 2019 12:13:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566907988; bh=aonEiOoI4N7zGZiyonXbquCAFE0htrxfMdE5k4O5cvI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=r7+GUXucUCf+6RNn0rQn1UUHqwUDMMbNQb5NUF0GkTYSsnth70khY+dUX8reBIUEd U5bJWEIE4ih7bTldadPEG08Zz2yiFGoYmlpFAfUUTJXgj7vSnfL0g6khFGBrvq11hN SElfUv8R7kG2LJlT5arqOCoVdnCOVpoKt9Hv29tI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728970AbfH0MNH (ORCPT ); Tue, 27 Aug 2019 08:13:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:39806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbfH0MNG (ORCPT ); Tue, 27 Aug 2019 08:13:06 -0400 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A13B921872; Tue, 27 Aug 2019 12:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566907984; bh=aonEiOoI4N7zGZiyonXbquCAFE0htrxfMdE5k4O5cvI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pk0OU1+LKCEsFAI5jInaf3ETd9t+tKrlFrvSWdPics5nhYt38Ds5jNxZw06XHYlei mEwKTE+wc/OqH6l5AhkueGzgccaXeJkTZc+Z3+v9B+0XewwFKwPLnaLyt8/ZV98bIr aocgVJAWzo0zDg43Xev2Qi1QgbjSSIsQ+5oHLaH0= Received: by mail-qk1-f171.google.com with SMTP id 4so1510609qki.6; Tue, 27 Aug 2019 05:13:04 -0700 (PDT) X-Gm-Message-State: APjAAAWPqUX02PYtmruXH2VJbWVjB2G5FP1TN2ZbGRSejb/vY6X7lqmU s1VjTq+vSO7C7Jm8qASHH54DuQudaDBWLuapgg== X-Google-Smtp-Source: APXvYqyobVuBJkxtt2J5Vqgl94929NSQZpwVLIffBY9bHymUp0I31gQKCn9/grMijIqD8+Buj7d1FFkojRRMupXUPvk= X-Received: by 2002:a37:8905:: with SMTP id l5mr3754099qkd.152.1566907983749; Tue, 27 Aug 2019 05:13:03 -0700 (PDT) MIME-Version: 1.0 References: <20190822172426.25879-1-manivannan.sadhasivam@linaro.org> <20190822172426.25879-5-manivannan.sadhasivam@linaro.org> In-Reply-To: <20190822172426.25879-5-manivannan.sadhasivam@linaro.org> From: Rob Herring Date: Tue, 27 Aug 2019 07:12:51 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 4/8] dt-bindings: clock: Add devicetree binding for BM1880 SoC To: Manivannan Sadhasivam Cc: Stephen Boyd , Michael Turquette , linux-clk , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, haitao.suo@bitmain.com, darren.tsao@bitmain.com, fisher.cheng@bitmain.com, alec.lin@bitmain.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2019 at 12:25 PM Manivannan Sadhasivam wrote: > > Add YAML devicetree binding for Bitmain BM1880 SoC. > > Signed-off-by: Manivannan Sadhasivam > --- > .../bindings/clock/bitmain,bm1880-clk.yaml | 74 +++++++++++++++++ > include/dt-bindings/clock/bm1880-clock.h | 82 +++++++++++++++++++ > 2 files changed, 156 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml > create mode 100644 include/dt-bindings/clock/bm1880-clock.h > > diff --git a/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml b/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml > new file mode 100644 > index 000000000000..31c48dcf5b8e > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: GPL-2.0+ Dual license please. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bindings/clock/bitmain,bm1880-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bitmain BM1880 Clock Controller > + > +maintainers: > + - Manivannan Sadhasivam > + > +description: | > + The Bitmain BM1880 clock controller generates and supplies clock to > + various peripherals within the SoC. > + > + This binding uses common clock bindings > + [1] Documentation/devicetree/bindings/clock/clock-bindings.txt > + > +properties: > + compatible: > + const: bitmain,bm1880-clk > + > + reg: > + items: > + - description: pll registers > + - description: system registers > + > + reg-names: > + items: > + - const: pll > + - const: sys > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: osc > + > + '#clock-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - reg-names > + - clocks > + - clock-names > + - '#clock-cells' additionalProperties: false > + > +examples: > + # Clock controller node: > + - | > + clk: clock-controller@e8 { > + compatible = "bitmain,bm1880-clk"; > + reg = <0xe8 0x0c>, <0x800 0xb0>; > + reg-names = "pll", "sys"; > + clocks = <&osc>; > + clock-names = "osc"; > + #clock-cells = <1>; > + }; > + > + # Example UART controller node that consumes clock generated by the clock controller: > + - | > + uart0: serial@58018000 { > + compatible = "snps,dw-apb-uart"; > + reg = <0x0 0x58018000 0x0 0x2000>; > + clocks = <&clk 45>, <&clk 46>; > + clock-names = "baudclk", "apb_pclk"; > + interrupts = <0 9 4>; > + reg-shift = <2>; > + reg-io-width = <4>; > + }; > + > +... > diff --git a/include/dt-bindings/clock/bm1880-clock.h b/include/dt-bindings/clock/bm1880-clock.h > new file mode 100644 > index 000000000000..b46732361b25 > --- /dev/null > +++ b/include/dt-bindings/clock/bm1880-clock.h > @@ -0,0 +1,82 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Device Tree binding constants for Bitmain BM1880 SoC > + * > + * Copyright (c) 2019 Linaro Ltd. > + */ > + > +#ifndef __DT_BINDINGS_CLOCK_BM1880_H > +#define __DT_BINDINGS_CLOCK_BM1880_H > + > +#define BM1880_CLK_OSC 0 > +#define BM1880_CLK_MPLL 1 > +#define BM1880_CLK_SPLL 2 > +#define BM1880_CLK_FPLL 3 > +#define BM1880_CLK_DDRPLL 4 > +#define BM1880_CLK_A53 5 > +#define BM1880_CLK_50M_A53 6 > +#define BM1880_CLK_AHB_ROM 7 > +#define BM1880_CLK_AXI_SRAM 8 > +#define BM1880_CLK_DDR_AXI 9 > +#define BM1880_CLK_EFUSE 10 > +#define BM1880_CLK_APB_EFUSE 11 > +#define BM1880_CLK_AXI5_EMMC 12 > +#define BM1880_CLK_EMMC 13 > +#define BM1880_CLK_100K_EMMC 14 > +#define BM1880_CLK_AXI5_SD 15 > +#define BM1880_CLK_SD 16 > +#define BM1880_CLK_100K_SD 17 > +#define BM1880_CLK_500M_ETH0 18 > +#define BM1880_CLK_AXI4_ETH0 19 > +#define BM1880_CLK_500M_ETH1 20 > +#define BM1880_CLK_AXI4_ETH1 21 > +#define BM1880_CLK_AXI1_GDMA 22 > +#define BM1880_CLK_APB_GPIO 23 > +#define BM1880_CLK_APB_GPIO_INTR 24 > +#define BM1880_CLK_GPIO_DB 25 > +#define BM1880_CLK_AXI1_MINER 26 > +#define BM1880_CLK_AHB_SF 27 > +#define BM1880_CLK_SDMA_AXI 28 > +#define BM1880_CLK_SDMA_AUD 29 > +#define BM1880_CLK_APB_I2C 30 > +#define BM1880_CLK_APB_WDT 31 > +#define BM1880_CLK_APB_JPEG 32 > +#define BM1880_CLK_JPEG_AXI 33 > +#define BM1880_CLK_AXI5_NF 34 > +#define BM1880_CLK_APB_NF 35 > +#define BM1880_CLK_NF 36 > +#define BM1880_CLK_APB_PWM 37 > +#define BM1880_CLK_DIV_0_RV 38 > +#define BM1880_CLK_DIV_1_RV 39 > +#define BM1880_CLK_MUX_RV 40 > +#define BM1880_CLK_RV 41 > +#define BM1880_CLK_APB_SPI 42 > +#define BM1880_CLK_TPU_AXI 43 > +#define BM1880_CLK_DIV_UART_500M 44 > +#define BM1880_CLK_UART_500M 45 > +#define BM1880_CLK_APB_UART 46 > +#define BM1880_CLK_APB_I2S 47 > +#define BM1880_CLK_AXI4_USB 48 > +#define BM1880_CLK_APB_USB 49 > +#define BM1880_CLK_125M_USB 50 > +#define BM1880_CLK_33K_USB 51 > +#define BM1880_CLK_DIV_12M_USB 52 > +#define BM1880_CLK_12M_USB 53 > +#define BM1880_CLK_APB_VIDEO 54 > +#define BM1880_CLK_VIDEO_AXI 55 > +#define BM1880_CLK_VPP_AXI 56 > +#define BM1880_CLK_APB_VPP 57 > +#define BM1880_CLK_DIV_0_AXI1 58 > +#define BM1880_CLK_DIV_1_AXI1 59 > +#define BM1880_CLK_AXI1 60 > +#define BM1880_CLK_AXI2 61 > +#define BM1880_CLK_AXI3 62 > +#define BM1880_CLK_AXI4 63 > +#define BM1880_CLK_AXI5 64 > +#define BM1880_CLK_DIV_0_AXI6 65 > +#define BM1880_CLK_DIV_1_AXI6 66 > +#define BM1880_CLK_MUX_AXI6 67 > +#define BM1880_CLK_AXI6 68 > +#define BM1880_NR_CLKS 69 > + > +#endif /* __DT_BINDINGS_CLOCK_BM1880_H */ > -- > 2.17.1 >