From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbdANCqV (ORCPT ); Fri, 13 Jan 2017 21:46:21 -0500 Received: from mail.kernel.org ([198.145.29.136]:44694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbdANCqT (ORCPT ); Fri, 13 Jan 2017 21:46:19 -0500 MIME-Version: 1.0 In-Reply-To: <1484245772-31511-1-git-send-email-sudeep.holla@arm.com> References: <1484245772-31511-1-git-send-email-sudeep.holla@arm.com> From: Rob Herring Date: Fri, 13 Jan 2017 20:45:55 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] of: base: add support to find the level of the last cache To: Sudeep Holla Cc: "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Will Deacon , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Tan Xiaojun , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 12:29 PM, Sudeep Holla wrote: > It is useful to have helper function just to get the number of cache > levels for a given logical cpu. We can obtain the same by just checking > the level at which the last cache is present. This patch adds support > to find the level of the last cache for a given cpu. > > It will be used on ARM64 platform where the device tree provides the > information for the additional non-architected/transparent/external > last level caches that are not integrated with the processors. > > Suggested-by: Rob Herring > Cc: Rob Herring > Cc: Mark Rutland > Signed-off-by: Sudeep Holla > --- > drivers/of/base.c | 27 +++++++++++++++++++++++++++ > include/linux/of.h | 1 + > 2 files changed, 28 insertions(+) > > v1->v2: > - Moved to using "cache-level" in the last level cache instead > of counting through all the nodes as suggested by Rob > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index d4bea3c797d6..c1128a077aea 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -2268,6 +2269,32 @@ struct device_node *of_find_next_cache_node(const struct device_node *np) > } > > /** > + * of_find_last_cache_level - Find the level at which the last cache is > + * present for the given logical cpu > + * > + * @cpu: cpu number(logical index) for which the last cache level is needed > + * > + * Returns the the level at which the last cache is present. It is exactly > + * same as the total number of cache levels for the given logical cpu. > + */ > +int of_find_last_cache_level(unsigned int cpu) > +{ > + int cache_level = 0; > + struct device_node *prev = NULL, *np = of_cpu_device_node_get(cpu); > + > + while (np) { > + prev = np; > + of_node_put(np); > + np = of_find_next_cache_node(np); > + } > + > + if (prev) Probably don't need this check. Otherwise, Acked-by: Rob Herring > + of_property_read_u32(prev, "cache-level", &cache_level); > + > + return cache_level; > +} > + > +/** > * of_graph_parse_endpoint() - parse common endpoint node properties > * @node: pointer to endpoint device_node > * @endpoint: pointer to the OF endpoint data structure > diff --git a/include/linux/of.h b/include/linux/of.h > index d72f01009297..21e6323de0f3 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -280,6 +280,7 @@ extern struct device_node *of_get_child_by_name(const struct device_node *node, > > /* cache lookup */ > extern struct device_node *of_find_next_cache_node(const struct device_node *); > +extern int of_find_last_cache_level(unsigned int cpu); > extern struct device_node *of_find_node_with_property( > struct device_node *from, const char *prop_name); > > -- > 2.7.4 >