From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F19FC3A5A3 for ; Tue, 27 Aug 2019 12:20:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5126206BF for ; Tue, 27 Aug 2019 12:20:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566908436; bh=10BPMi7ogBKEVUWUCp+OlUh6tWIYmElWTtO/pbCLCfE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=wGrW7i1zNO0cdc1NAhndZfn4fAp2frpvvwgugF9qeFEDSL/edPkxF0rmW1KbqouUl OwOQJgwkdYR1Hx+RhuWwVnvCOO//4onnFPt/gtStBYM+CCQ9wBRhJAGS6AbKpt0CkD ZMjKdohIp8X5f59UnoOE1GDwwx7cvb9UhTeRITi4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728222AbfH0MUg (ORCPT ); Tue, 27 Aug 2019 08:20:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:43644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfH0MUf (ORCPT ); Tue, 27 Aug 2019 08:20:35 -0400 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E7816206BF; Tue, 27 Aug 2019 12:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566908434; bh=10BPMi7ogBKEVUWUCp+OlUh6tWIYmElWTtO/pbCLCfE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hiSjrNzN9O29H/jZozkaXJ1RY7B2iPUnmPqzXqXAfbEHqvCNs2qwYPYjz+fe0bIVP 3OWIUxGwCDw0ICc9roj00pPsDU+tYy6PMcG/TCSw0YwM5ErWb8psm8Fm/gJJGcB7wT Gdyvjxn2TXOQ9wvf0rvh4w1k9UfLYSxEan4/ebTw= Received: by mail-qt1-f176.google.com with SMTP id q64so9348813qtd.5; Tue, 27 Aug 2019 05:20:33 -0700 (PDT) X-Gm-Message-State: APjAAAXzNhZ+egjyhcIPGnxugc26lJPigKtAR8jh6r9xYli+sf86xObF 5Rsx9eMA9EiXMdbzNfqEUK8f8qMr+nFyvoQexQ== X-Google-Smtp-Source: APXvYqwMqxGiTa7rYYydtko9BqUul5ihk660b1Rd0cPJHim/fp9+Uq5BxXYH75v80lYawW9Ve2rEL384NDhcnbTwKFM= X-Received: by 2002:a05:6214:10e1:: with SMTP id q1mr19735401qvt.148.1566908433096; Tue, 27 Aug 2019 05:20:33 -0700 (PDT) MIME-Version: 1.0 References: <20190822233759.12663-1-srinivas.kandagatla@linaro.org> <20190822233759.12663-4-srinivas.kandagatla@linaro.org> In-Reply-To: <20190822233759.12663-4-srinivas.kandagatla@linaro.org> From: Rob Herring Date: Tue, 27 Aug 2019 07:20:21 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RESEND PATCH v4 3/4] dt-bindings: ASoC: Add WSA881x bindings To: Srinivas Kandagatla Cc: Mark Brown , Vinod , spapothi@codeaurora.org, Banajit Goswami , Linux-ALSA , "linux-kernel@vger.kernel.org" , Liam Girdwood , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 22, 2019 at 6:38 PM Srinivas Kandagatla wrote: > > This patch adds bindings for WSA8810/WSA8815 Class-D Smart Speaker > Amplifier. This Amplifier also has a simple thermal sensor for > over temperature and speaker protection. > > Signed-off-by: Srinivas Kandagatla > --- > .../bindings/sound/qcom,wsa881x.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml > new file mode 100644 > index 000000000000..ad718d75c660 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,wsa881x.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,wsa881x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Qualcomm WSA8810/WSA8815 Class-D Smart Speaker Amplifier > + > +maintainers: > + - Srinivas Kandagatla > + > +allOf: > + - $ref: "soundwire-controller.yaml#" This is not the controller, so this should not be included here. You should get lots of warnings from doing so. You did run 'make dt_binding_check', right? > + > +properties: > + compatible: > + const: sdw10217201000 > + > + reg: > + maxItems: 1 > + > + pd-gpios: powerdown-gpios is the standard name. > + description: GPIO spec for Powerdown/Shutdown line to use > + maxItems: 1 > + > + "#thermal-sensor-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - pd-gpios > + - #thermal-sensor-cells > + > +examples: > + - | > + efuse@1c23800 { > + compatible = "allwinner,sun4i-a10-sid"; Huh? > + reg = <0x01c23800 0x10>; > + pd-gpios = <&wcdpinctrl 2 0>; > + #thermal-sensor-cells = <0>; > + }; > + > +... > -- > 2.21.0 >