From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FCCC4338F for ; Mon, 26 Jul 2021 20:36:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A58160F6E for ; Mon, 26 Jul 2021 20:36:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232917AbhGZT4D (ORCPT ); Mon, 26 Jul 2021 15:56:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:55436 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232359AbhGZT4A (ORCPT ); Mon, 26 Jul 2021 15:56:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F3FD360F94; Mon, 26 Jul 2021 20:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627331789; bh=3riA8t9dhiYBRD1Zo/I1Hj+SO5jhDplsAp2AKdHWpLA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZeC55X+ii1EFrVqG2LhhEpFJ2XVlWO5U5yR0AYGD74kDstUM1REQDsHuLGCWniMoS s8+NIMUQQ1rs+71RkwXWbTnXGDstWix4QcNh+x2IE+eW9W/I26hqk2bWvnEG23BASd aBSUnxfvn3MO2+I/ZQie+fjcnr4EmLmYSJOy8u8ydz8F5w3zuPTT0GZwHpW998kZ5q bcS+SGXJWjOOH/DYHw2QLiQGxvZDhSCLfT7Wbatnft/6+1oDCRJh0bgjJIfN1SG7Uv 0V2cwoIIPog1oCrEnX40WM4icReRQVdfmxOLrcTPMG1JrIpgnYGB2IgvXZ8Mz3czdm PiviFHOObmzLA== Received: by mail-ed1-f51.google.com with SMTP id r16so12298534edt.7; Mon, 26 Jul 2021 13:36:28 -0700 (PDT) X-Gm-Message-State: AOAM533YQuUOOfGGtIqnGCSgVO1PB+TSiSJRflmPqPjIyPfcN5+/9WuZ jFxDmc1kA+JAZQChb9kRqhmvjFU6IIoeKVIFaQ== X-Google-Smtp-Source: ABdhPJxJvbq2g1KVho0J4ni/dJfg/SR6NMsVddzMiVey2KHzvQfwm0Lk820JJcWPeqiRPXYyscNT4jTklDKfEDPvWFc= X-Received: by 2002:aa7:da4b:: with SMTP id w11mr24326198eds.258.1627331787560; Mon, 26 Jul 2021 13:36:27 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Rob Herring Date: Mon, 26 Jul 2021 14:36:14 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices To: Arnd Bergmann Cc: Viresh Kumar , Jason Wang , "Michael S. Tsirkin" , Jean-Philippe Brucker , Vincent Guittot , Bill Mills , =?UTF-8?B?QWxleCBCZW5uw6ll?= , "Enrico Weigelt, metux IT consult" , Jie Deng , DTML , "linux-kernel@vger.kernel.org" , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 9:54 AM Arnd Bergmann wrote: > > On Mon, Jul 26, 2021 at 4:57 PM Rob Herring wrote: > > On Sun, Jul 25, 2021 at 10:52 PM Viresh Kumar wrote: > > > + description: | > > > + Exactly one node describing the virtio device. The name of the node isn't > > > + significant but its phandle can be used to by a user of the virtio device. > > > + > > > + compatible: > > > + pattern: "^virtio,[0-9a-f]+$" > > > > DID is only 4 chars? If so, "^virtio,[0-9a-f]{1,4}$" > > Any opinion on whether this should have any namespace prefix (or infix, I guess) > after "virtio,"? > > I previously suggested making it "virtio,device[0-9a-f]{1,4}$", which would > make it clearer that the following digits are the device ID rather > than something > else we might define in the future. Viresh picked this version because it's > somewhat more consistent with other subsystems. I'm fine either way, though I do find just a number a bit strange. So I'd lean toward adding 'device' or even just a 'd'. BTW, what happens if/when the device protocol is rev'ed? A new DID or is there a separate revision that's discoverable? Rob