From: Rob Herring <robh@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Frank Rowand <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 3/3] of/property: Add of_fwnode_name()
Date: Fri, 14 Dec 2018 11:46:02 -0600 [thread overview]
Message-ID: <CAL_JsqLn3dbt-8Hjoja5AJip7FxLoWLAh0Cuk1eqE3Z8RiaO1A@mail.gmail.com> (raw)
In-Reply-To: <CAJZ5v0hvGL8DnxFAtp3NiuT7ubTBuoKbTzbD9UaZYNpgZLiWaQ@mail.gmail.com>
On Fri, Dec 14, 2018 at 3:36 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Dec 11, 2018 at 2:15 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > This implements get_name fwnode op for DT.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> Rob, any objections here?
Yes, what I said in v5.
At one point this series had a user which was finding a matching node
by name. Now there is no user, so I can't really say whether this API
makes sense or not.
There's generally only 2 uses for 'name' at least for DT. The first is
node matching by name. ICYMI, every case of that in the tree is now
replaced with of_node_name_eq(). Now the details of matching by node
name are contained within the DT API. The 2nd use of node names is
just informational purposes or to fill some other structure's name
string (e.g. struct resource). In these cases, device_node.full_name
can be used. The only difference is full_name includes the unit
address ('@1234' part) if there is one. For these uses, the kernel
shouldn't generally care what the name actually is, but that's not
really enforceable.
Rob
next prev parent reply other threads:[~2018-12-14 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 13:14 [PATCH v6 0/3] device property: Add fwnode_get_name() helper Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 1/3] device property: Introduce fwnode_get_name() Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 2/3] ACPI: property: Add acpi_fwnode_name() Heikki Krogerus
2018-12-11 13:14 ` [PATCH v6 3/3] of/property: Add of_fwnode_name() Heikki Krogerus
2018-12-14 9:36 ` Rafael J. Wysocki
2018-12-14 17:46 ` Rob Herring [this message]
2018-12-17 12:15 ` Heikki Krogerus
2018-12-11 13:59 ` [PATCH v6 0/3] device property: Add fwnode_get_name() helper Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLn3dbt-8Hjoja5AJip7FxLoWLAh0Cuk1eqE3Z8RiaO1A@mail.gmail.com \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).