From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F43C43457 for ; Tue, 13 Oct 2020 13:43:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBE8324753 for ; Tue, 13 Oct 2020 13:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602596637; bh=YO2PDs3lYloGofhsa8LTWOri/oY42O9bpA7iUsBsEf8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=aCThAR1HZcTWmykomuiCHnPkZU2xBnOWyM0f2F/U4cumchhiCkRIkWspvDSvF6bOQ e2qvwQGlB4mgXjIfLOJ2GveoEEkkJhqDYEIc4wSxFgkFZFtkybai0MvjASGeSyb/uS XV/PA76ZXjL9U5tzio0ZGjI543gD4DmQtUY4jhKo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387783AbgJMNn4 (ORCPT ); Tue, 13 Oct 2020 09:43:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:44102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387694AbgJMNn4 (ORCPT ); Tue, 13 Oct 2020 09:43:56 -0400 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD3DF2475A; Tue, 13 Oct 2020 13:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602596636; bh=YO2PDs3lYloGofhsa8LTWOri/oY42O9bpA7iUsBsEf8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QRB5ToLr1XeghspTWZnX4kPUDWAoFuDwTVI7OgTShxQtoE+nJQq0lESdtJfAz540G QJxTqFHOZMa0FSQHGfBulHZzGYSxdW5deUGMstZGL1betVugqs99Vk/ZZJxI7FEr1a s2fXHiIry1wsvxx7Xgwx7OxHzExGxDVTWFk7lFKw= Received: by mail-ot1-f42.google.com with SMTP id m11so19035250otk.13; Tue, 13 Oct 2020 06:43:55 -0700 (PDT) X-Gm-Message-State: AOAM533wa5r8KEtS4NB8dGcQdMKkLG3qoTwmkQEhseaqFq2V3I9EDQfo d02JktiOcrhvCDYnVValOdTEu13b3eg/E0qJIA== X-Google-Smtp-Source: ABdhPJx8BldmCpfMxn+SFOS5Dwk2xbrqTUFXlkpLHjC3ZhXrXyxuJZCFCnxfbBvRV1KtGLA76IMsOGHqg/L39PJZqs4= X-Received: by 2002:a9d:7993:: with SMTP id h19mr18795049otm.129.1602596635090; Tue, 13 Oct 2020 06:43:55 -0700 (PDT) MIME-Version: 1.0 References: <20200929024004.244992-1-badhri@google.com> <20200929024004.244992-4-badhri@google.com> <20201005144618.GA154206@bogus> In-Reply-To: From: Rob Herring Date: Tue, 13 Oct 2020 08:43:44 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v9 03/15] dt-bindings: usb: Maxim type-c controller device tree binding document To: Badhri Jagan Sridharan Cc: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman , Lee Jones , Mark Brown , Maxime Ripard , Alexandre Belloni , Thierry Reding , Prashant Malani , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , USB Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 7, 2020 at 7:43 PM Badhri Jagan Sridharan wrote: > > Hi Robb, > > Thanks for the reviews ! Responses inline. > > Regards, > Badhri > > On Mon, Oct 5, 2020 at 7:46 AM Rob Herring wrote: > > > > On Mon, Sep 28, 2020 at 07:39:52PM -0700, Badhri Jagan Sridharan wrote: > > > Add device tree binding document for Maxim TCPCI based Type-C chip driver > > > > > > Signed-off-by: Badhri Jagan Sridharan > > > --- > > > Changes since v1: > > > - Changing patch version to v6 to fix version number confusion. > > > > > > Changes since v6: > > > - Migrated to yaml format. > > > > > > Changes since v7: > > > - Rebase on usb-next > > > > > > Changes since v8: > > > - Fix errors from make dt_binding_check as suggested by > > > Rob Herring. > > > --- > > > .../devicetree/bindings/usb/maxim,tcpci.yaml | 68 +++++++++++++++++++ > > > 1 file changed, 68 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml b/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > > new file mode 100644 > > > index 000000000000..f4b5f1a09b98 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/usb/maxim,tcpci.yaml > > > @@ -0,0 +1,68 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: "http://devicetree.org/schemas/usb/maxim,tcpci.yaml#" > > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > > + > > > +title: Maxim TCPCI Type-C PD controller DT bindings > > > + > > > +maintainers: > > > + - Badhri Jagan Sridharan > > > + > > > +description: Maxim TCPCI Type-C PD controller > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - maxim,tcpci > > > > Is there a datasheet for this? Searching for 'tcpci' doesn't really come > > up with anything other than this patch. Only chip I found is MAX77958. > > Bindings are for specific h/w devices. > > Unfortunately the datasheet cannot be made public yet. Has the datasheet > have to be made public before sending the bindings ? No, but we need a part number or some assurance that 'tcpci' is a specific part. Rob