From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E84ADC433E1 for ; Fri, 22 May 2020 22:53:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C59562073B for ; Fri, 22 May 2020 22:53:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590187981; bh=s8VDJ5q/XWeba0JwJLGwDHvWdnM6xBSge8cHIo1DMdI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=X3i8qvmNYFSyoiToUCSQxBvBOv5TuauR9p7ihykah59vUyr2YVj1NPNyi7XOuD66x Q53E0KVNIkPDLEIITP3PHbUUuK1Mk/qW4kcmcflnCDiymXw2kOz1uLSEOT6Jus1xAz JqI5ifjEdbS8A1lSrvAr25WHPQaPbprimus/CDXk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731279AbgEVWxB (ORCPT ); Fri, 22 May 2020 18:53:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:58084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731029AbgEVWxA (ORCPT ); Fri, 22 May 2020 18:53:00 -0400 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC99B20738; Fri, 22 May 2020 22:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590187980; bh=s8VDJ5q/XWeba0JwJLGwDHvWdnM6xBSge8cHIo1DMdI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=EDyNLY76iMkjGVhS32UCOKEErCkTNQH2O+HoFaWXBhjQQnP3AMKoGDk3T+8mJWQxq Gx9eZMg8Tds+AXe1soZ+kGnxGMy0naxSRCJWMUPBv+gVnIGoJ9M6evKgWREWikw4tW HU3H+2efHb7zGiW9rHMWMEQwdAJy7lti26/Fk91A= Received: by mail-ot1-f42.google.com with SMTP id h7so9491236otr.3; Fri, 22 May 2020 15:52:59 -0700 (PDT) X-Gm-Message-State: AOAM533EjZ7oLTAYrxu+4QstNR07uobgjDXloKtNYDZFRD9oZx4bfcwS W8/zdHmG+De1mkyNleKGeBznqt3nh42b1bHbSw== X-Google-Smtp-Source: ABdhPJxU1+qD6w9ay3ewdggkUSX+5KRHsqDIDY8eLsvHjqoPE2I4T80lfE37U9QbanvESgeWms8o5QSqcw//Nx7f4Ew= X-Received: by 2002:a05:6830:3104:: with SMTP id b4mr1685905ots.192.1590187979235; Fri, 22 May 2020 15:52:59 -0700 (PDT) MIME-Version: 1.0 References: <20200522220103.908307-1-anders.roxell@linaro.org> In-Reply-To: <20200522220103.908307-1-anders.roxell@linaro.org> From: Rob Herring Date: Fri, 22 May 2020 16:52:40 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] power: reset: vexpress: fix build issue To: Anders Roxell Cc: Geert Uytterhoeven , Magnus Damm , "open list:MEDIA DRIVERS FOR RENESAS - FCP" , Sebastian Reichel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 22, 2020 at 4:01 PM Anders Roxell wrote: > It's soc@kernel.org that this needs to go to with an explicit request for them to apply. Please resend so it gets in their Patchwork. > An allmodconfig kernel makes CONFIG_VEXPRESS_CONFIG a module and > CONFIG_POWER_RESET_VEXPRESS builtin. That makes us see this build > error: > > aarch64-linux-gnu-ld: drivers/power/reset/vexpress-poweroff.o: in function `vexpress_reset_probe': > ../drivers/power/reset/vexpress-poweroff.c:119: undefined reference to `devm_regmap_init_vexpress_config' > ../drivers/power/reset/vexpress-poweroff.c:119:(.text+0x48c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol > `devm_regmap_init_vexpress_config' > make[1]: *** [/srv/src/kernel/next/Makefile:1126: vmlinux] Error 1 > > Rework so that POWER_RESET_VEXPRESS depends on 'VEXPRESS_CONFIG=y'. > > Fixes: d06cfe3f123c ("bus: vexpress-config: Merge vexpress-syscfg into vexpress-config") > Acked-by: Rob Herring > Signed-off-by: Anders Roxell > --- > drivers/power/reset/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > index 4dfac618b942..f07b982c8dff 100644 > --- a/drivers/power/reset/Kconfig > +++ b/drivers/power/reset/Kconfig > @@ -191,7 +191,7 @@ config POWER_RESET_VERSATILE > config POWER_RESET_VEXPRESS > bool "ARM Versatile Express power-off and reset driver" > depends on ARM || ARM64 > - depends on VEXPRESS_CONFIG > + depends on VEXPRESS_CONFIG=y > help > Power off and reset support for the ARM Ltd. Versatile > Express boards. > -- > 2.26.2 >