From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FD4BC433E0 for ; Tue, 4 Aug 2020 02:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18EB820792 for ; Tue, 4 Aug 2020 02:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596506481; bh=4XVqqgwktGruGGFjT+GJfaOJ/4GWRFCLq8E7Ac4NJeM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=V/kLTtCkqQarNn/04omhoKBlht3y+MbbU4Bxd3NAwslw2aOh27uRWSn00BHOk6m0q oWbCik0Y29spLnJD++rbj9pP3vm0pTRMTW3HejRs2IK3hIIwULOTynVLM9hybCrlWk 2R2sTXVwlb1SosQMKq9E8healBaI5KZWCaucqM3E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbgHDCBT (ORCPT ); Mon, 3 Aug 2020 22:01:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:47614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbgHDCBT (ORCPT ); Mon, 3 Aug 2020 22:01:19 -0400 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8A95220792; Tue, 4 Aug 2020 02:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596506478; bh=4XVqqgwktGruGGFjT+GJfaOJ/4GWRFCLq8E7Ac4NJeM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=s7Qh5+Lxr+2nDRrGsJ0Yq6A9rR6jlqp0FqJ/GFWzSLjwbl1ob1p2kW+orUqP/UbJk 2Xwqjt0wHyyMv/vkMx9rIMQ/78hIlHhANg6hlpQem6KNvWN8cwMjtVLLOyQ382649l PLdpkXwlxAyRZ2msArinhyUhPJ7Yp1hqYpdnLViE= Received: by mail-oi1-f180.google.com with SMTP id l84so22494014oig.10; Mon, 03 Aug 2020 19:01:18 -0700 (PDT) X-Gm-Message-State: AOAM531pb9nPlaBn2CqhbmbXm3HuRADXrr2QBahyK2NhWG/OFRpoz9dR iP3PkIWsDwdAva9ejGrwUp9ROgEmgzA8vexKFw== X-Google-Smtp-Source: ABdhPJybkTGDHYJ7RbW8usE+aYAZuvyH9Qf4GxLxWv9aK7s5b4rphMB8CDwUhA8saSycpJZznnMHvSF2z7+MYaTpAkg= X-Received: by 2002:aca:c3d8:: with SMTP id t207mr1037981oif.152.1596506477732; Mon, 03 Aug 2020 19:01:17 -0700 (PDT) MIME-Version: 1.0 References: <20200731164853.3020946-1-campello@chromium.org> <20200731104555.v3.1.I0925046377211b8b6f06764857f03b4ab592bddb@changeid> <20200801160639.1410944e@archlinux> <159648122347.1360974.1094560524092762187@swboyd.mtv.corp.google.com> In-Reply-To: <159648122347.1360974.1094560524092762187@swboyd.mtv.corp.google.com> From: Rob Herring Date: Mon, 3 Aug 2020 20:01:06 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 01/15] dt-bindings: iio: Add bindings for sx9310 sensor To: Stephen Boyd Cc: Daniel Campello , Jonathan Cameron , LKML , LKML , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Douglas Anderson , "open list:IIO SUBSYSTEM AND DRIVERS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 3, 2020 at 1:00 PM Stephen Boyd wrote: > > Quoting Jonathan Cameron (2020-08-01 08:06:39) > > On Fri, 31 Jul 2020 10:48:38 -0600 > > Daniel Campello wrote: > > > diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml > > > new file mode 100644 > > > index 00000000000000..5739074d3592fe > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9310.yaml > > > @@ -0,0 +1,65 @@ > [...] > > > + > > > + "#io-channel-cells": > > > + const: 1 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - "#io-channel-cells" > > > > Missed this in earlier review (only noticed when I saw whilst santity > > checking earlier versions. > > > > Fairly sure we should only need #io-channel-cells if we have > > a consumer of a channel somewhere else in DT. So it's not > > required as far as I can see. > > > > This is mostly a decision for Rob to make, but I would make it required > because the device is always an io channel provider. It may be that it > isn't providing anything in the DT to something else in the DT but it is > providing this information somewhere so always having to spell that out > is simple and doesn't hurt. I agree. If the user is split in a board file or overlay, we don't want to have to be adding it to the provider at that time. Rob