From: Rob Herring <robh+dt@kernel.org>
To: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
"Gross, Andy" <agross@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, judyhsiao@chromium.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
Patrick Lai <plai@codeaurora.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v4 1/2] ASoC: google: dt-bindings: Add sc7280-herobrine machine bindings
Date: Fri, 5 Nov 2021 20:30:20 -0500 [thread overview]
Message-ID: <CAL_JsqLxJ4HYUEcdCu-5EiakXe9e3yueOdxRa24K2r04F1Zqeg@mail.gmail.com> (raw)
In-Reply-To: <0cf52203-249a-2f6c-6106-888631ac85fa@codeaurora.org>
On Tue, Nov 2, 2021 at 5:57 AM Srinivasa Rao Mandadapu
<srivasam@codeaurora.org> wrote:
>
>
> On 10/30/2021 12:37 AM, Stephen Boyd wrote:
> Thanks for Your time Stephen!!!
> > Quoting Srinivasa Rao Mandadapu (2021-10-29 08:04:35)
> >> diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> >> new file mode 100644
> >> index 0000000..3a781c8
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml
> >> @@ -0,0 +1,170 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/sound/google,sc7280-herobrine.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Google SC7280-Herobrine ASoC sound card driver
> >> +
> >> +maintainers:
> >> + - Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> >> + - Judy Hsiao <judyhsiao@chromium.org>
> >> +
> >> +description:
> >> + This binding describes the SC7280 sound card which uses LPASS for audio.
> >> +
> >> +properties:
> >> + compatible:
> >> + enum:
> >> + - google,sc7280-herobrine
> >> +
> >> + audio-routing:
> >> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> >> + description:
> >> + A list of the connections between audio components. Each entry is a
> >> + pair of strings, the first being the connection's sink, the second
> >> + being the connection's source.
> >> +
> >> + model:
> >> + $ref: /schemas/types.yaml#/definitions/string
> >> + description: User specified audio sound card name
> >> +
> >> + "#address-cells":
> >> + const: 1
> >> +
> >> + "#size-cells":
> >> + const: 0
> >> +
> >> +patternProperties:
> >> + "^dai-link@[0-9a-f]$":
> >> + description:
> >> + Each subnode represents a dai link. Subnodes of each dai links would be
> >> + cpu/codec dais.
> >> +
> >> + type: object
> >> +
> >> + properties:
> >> + link-name:
> >> + description: Indicates dai-link name and PCM stream name.
> >> + $ref: /schemas/types.yaml#/definitions/string
> >> + maxItems: 1
> >> +
> >> + reg:
> >> + maxItems: 1
> >> + description: dai link address.
> >> +
> >> + cpu:
> >> + description: Holds subnode which indicates cpu dai.
> >> + type: object
> >> + properties:
> >> + sound-dai: true
> > Is sound-dai required? And additionalProperties is false? I think we
> > need that yet again.
> Okay. Will mark additionalPropertiesas true.
'additiionalProperties: true' is almost never right. It's generally
only correct for schemas that are incomplete collections of
properties.
Rob
next prev parent reply other threads:[~2021-11-06 1:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 15:04 [PATCH v4 0/2] Machine driver to support LPASS SC7280 sound card registration Srinivasa Rao Mandadapu
2021-10-29 15:04 ` [PATCH v4 1/2] ASoC: google: dt-bindings: Add sc7280-herobrine machine bindings Srinivasa Rao Mandadapu
2021-10-29 19:07 ` Stephen Boyd
2021-11-02 10:56 ` Srinivasa Rao Mandadapu
2021-11-06 1:30 ` Rob Herring [this message]
2021-11-08 7:35 ` Srinivasa Rao Mandadapu
2021-11-08 14:00 ` Rob Herring
2021-10-29 21:15 ` Rob Herring
2021-10-29 15:04 ` [PATCH v4 2/2] ASoC: qcom: SC7280: Add machine driver Srinivasa Rao Mandadapu
2021-10-29 19:10 ` Stephen Boyd
2021-11-02 11:01 ` Srinivasa Rao Mandadapu
2021-10-29 23:34 ` Randy Dunlap
2021-11-02 10:58 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLxJ4HYUEcdCu-5EiakXe9e3yueOdxRa24K2r04F1Zqeg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).