From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751528AbdBIFKx (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 00:10:53 -0500
Received: from mail-vk0-f48.google.com ([209.85.213.48]:35909 "EHLO
        mail-vk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751371AbdBIFKw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 00:10:52 -0500
MIME-Version: 1.0
In-Reply-To: <20170208132416.GE6668@kernel.org>
References: <CALcN6miT9VzeevAkZsyioFF2Evf8xKGyn9PKXRV=vvuQohe8pQ@mail.gmail.com>
 <20170208052840.112182-1-davidcc@google.com> <20170208124450.GD6668@kernel.org>
 <20170208132416.GE6668@kernel.org>
From: David Carrillo-Cisneros <davidcc@google.com>
Date: Wed, 8 Feb 2017 21:03:36 -0800
Message-ID: <CALcN6mhAd6pti2fD9KL6y=83ENN-M5=1v7HOWXhRRitdirMd=A@mail.gmail.com>
Subject: Re: [PATCH v2] tools lib traceevent: Robustify do_generate_dynamic_list_file
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Wang Nan <wangnan0@huawei.com>, He Kuang <hekuang@huawei.com>,
        Michal Marek <mmarek@suse.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> bash has some shell opts to control some aspects of compatibility with string
> comparisions that could have some default different from ubuntu and fedora,
> I couldn't find one that looked related, sigh.

The joys of batch scripting...

>
> Anyway, the difference in the order of the symbol types is related to locales, which
> are fixed in the Makefiles to avoid those problems, so in both Fedora and Ubuntu
> that symbol_type evaluates to "U W w" and the file is generated as intended.
>
> So I'm just replacing == with = and running a new set of container based distro tests.
>

"=" works fine in my build. Thanks for looking into this. Next time I
will pay attention to bash portability.

Thanks,
David