From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754880AbdDLQep (ORCPT <rfc822;w@1wt.eu>);
        Wed, 12 Apr 2017 12:34:45 -0400
Received: from mail-pg0-f46.google.com ([74.125.83.46]:33337 "EHLO
        mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752544AbdDLQej (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 12 Apr 2017 12:34:39 -0400
MIME-Version: 1.0
In-Reply-To: <20170412081721.GC17517@krava>
References: <20170412064919.92449-1-davidcc@google.com> <20170412064919.92449-6-davidcc@google.com>
 <20170412081721.GC17517@krava>
From: David Carrillo-Cisneros <davidcc@google.com>
Date: Wed, 12 Apr 2017 09:34:37 -0700
Message-ID: <CALcN6mhCpTBvcO2Xt4388HMY0a1KLoJFM=4N2mQ3E91rp3g2fg@mail.gmail.com>
Subject: Re: [PATCH 4/6] perf report: hint .perfconfig error when invalid
 sorting key
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>, Simon Que <sque@chromium.org>,
        Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        He Kuang <hekuang@huawei.com>, Masami Hiramatsu <mhiramat@kernel.org>,
        Stephane Eranian <eranian@google.com>, Paul Turner <pjt@google.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Tue, Apr 11, 2017 at 11:49:17PM -0700, David Carrillo-Cisneros wrote:
>> My fat-fingering of sort keys in .perfconfig was a common cause of
>> perf report silently terminating without apparent error.
>>
>> This was because 1) error in setup_sorting in cmd_report was ignored
>> and 2) no message was log in UI browser that would prevent UI from
>> exit before user prompt. Fix both.
>
> there's UI init ahead of this code.. I had to move it
> below your code to spot any error message
>
> there's other errors further on.. perhaps we should move it even further ;-)
> or cancel the ui before the error is printed

Probably canceling ui on error is the more robust way to go. I will
look into it.

Thanks,
David

>
> jirka
>
>
> ---
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 19a69ca0e9c9..abcf3aadca9e 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -982,11 +982,6 @@ int cmd_report(int argc, const char **argv)
>         if (report.header || report.header_only || report.show_threads)
>                 use_browser = 0;
>
> -       if (strcmp(input_name, "-") != 0)
> -               setup_browser(true);
> -       else
> -               use_browser = 0;
> -
>         ret = setup_sorting(session->evlist);
>         if (ret < 0) {
>                 if (sort_order)
> @@ -999,6 +994,11 @@ int cmd_report(int argc, const char **argv)
>                 goto error;
>         }
>
> +       if (strcmp(input_name, "-") != 0)
> +               setup_browser(true);
> +       else
> +               use_browser = 0;
> +
>         if ((report.header || report.header_only) && !quiet) {
>                 perf_session__fprintf_info(session, stdout,
>                                            report.show_full_info);