LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions
@ 2020-08-21  3:12 George Acosta
  2020-08-28  7:19 ` Herbert Xu
  0 siblings, 1 reply; 4+ messages in thread
From: George Acosta @ 2020-08-21  3:12 UTC (permalink / raw)
  To: acostag.ubuntu
  Cc: Herbert Xu, David S. Miller, Christophe JAILLET,
	Gustavo A. R. Silva, Phani Kiran Hemadri, linux-crypto,
	linux-kernel

Provide an error message for users when pci_request_mem_regions failed.

Signed-off-by: George Acosta <acostag.ubuntu@gmail.com>
---
 drivers/crypto/cavium/nitrox/nitrox_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
index cee2a2713038..9d14be97e381 100644
--- a/drivers/crypto/cavium/nitrox/nitrox_main.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_main.c
@@ -451,6 +451,7 @@ static int nitrox_probe(struct pci_dev *pdev,
 	err = pci_request_mem_regions(pdev, nitrox_driver_name);
 	if (err) {
 		pci_disable_device(pdev);
+		dev_err(&pdev->dev, "Failed to request mem regions!\n");
 		return err;
 	}
 	pci_set_master(pdev);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions
  2020-08-21  3:12 [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions George Acosta
@ 2020-08-28  7:19 ` Herbert Xu
  2020-08-29  1:53   ` George Acosta
  0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2020-08-28  7:19 UTC (permalink / raw)
  To: George Acosta
  Cc: David S. Miller, Christophe JAILLET, Gustavo A. R. Silva,
	Phani Kiran Hemadri, linux-crypto, linux-kernel

On Thu, Aug 20, 2020 at 10:12:08PM -0500, George Acosta wrote:
> Provide an error message for users when pci_request_mem_regions failed.
> 
> Signed-off-by: George Acosta <acostag.ubuntu@gmail.com>
> ---
>  drivers/crypto/cavium/nitrox/nitrox_main.c | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions
  2020-08-28  7:19 ` Herbert Xu
@ 2020-08-29  1:53   ` George Acosta
  2020-08-29 12:04     ` Herbert Xu
  0 siblings, 1 reply; 4+ messages in thread
From: George Acosta @ 2020-08-29  1:53 UTC (permalink / raw)
  To: Herbert Xu
  Cc: David S. Miller, Christophe JAILLET, Gustavo A. R. Silva,
	Phani Kiran Hemadri, linux-crypto, linux-kernel

Hi Herbert,
I just noticed a small potential issue about the calling sequence of
pci_disable_device and dev_err.
Do you think it will be better to call dev_err before we call
pci_disable_device(pdev) , or the order here does not matter?

On Fri, Aug 28, 2020 at 2:19 AM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Thu, Aug 20, 2020 at 10:12:08PM -0500, George Acosta wrote:
> > Provide an error message for users when pci_request_mem_regions failed.
> >
> > Signed-off-by: George Acosta <acostag.ubuntu@gmail.com>
> > ---
> >  drivers/crypto/cavium/nitrox/nitrox_main.c | 1 +
> >  1 file changed, 1 insertion(+)
>
> Patch applied.  Thanks.
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


Thanks,
George

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions
  2020-08-29  1:53   ` George Acosta
@ 2020-08-29 12:04     ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2020-08-29 12:04 UTC (permalink / raw)
  To: George Acosta
  Cc: David S. Miller, Christophe JAILLET, Gustavo A. R. Silva,
	Phani Kiran Hemadri, linux-crypto, linux-kernel

On Fri, Aug 28, 2020 at 08:53:36PM -0500, George Acosta wrote:
> Hi Herbert,
> I just noticed a small potential issue about the calling sequence of
> pci_disable_device and dev_err.
> Do you think it will be better to call dev_err before we call
> pci_disable_device(pdev) , or the order here does not matter?

I don't think it matters.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21  3:12 [PATCH] crypto: cavium/nitrox: add an error message to explain the failure of pci_request_mem_regions George Acosta
2020-08-28  7:19 ` Herbert Xu
2020-08-29  1:53   ` George Acosta
2020-08-29 12:04     ` Herbert Xu

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
	git clone --mirror https://lore.kernel.org/lkml/10 lkml/git/10.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git