From: Dmitry Mastykin <mastichi@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Rob Herring <robh@kernel.org>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: adc: max9611: fix module auto-loading
Date: Sat, 30 Dec 2017 15:43:38 +0300 [thread overview]
Message-ID: <CALieaeeZXZ-6WKYXSMgLiiTO6eTFvdJjazOY9wx4VFk7YcA4Lg@mail.gmail.com> (raw)
In-Reply-To: <20171229175449.760e734d@archlinux>
> On Fri, 29 Dec 2017 17:30:39 +0200
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>>
I was not aware of this tag, that's what I wanted to write, thanks!
On Fri, Dec 29, 2017 at 8:54 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> I'm a little confused. Why does this now make module autoloading
> work where it previously didn't?
>
As I understand, .probe is not called if module doesn't export i2c id table,
there is nothing to put into second argument.
But .probe_new is called, because it's supposed to do of_match_device itself.
Kind regards,
Dmitry
>> > Signed-off-by: Dmitry Mastykin <mastichi@gmail.com>
>> > ---
>> > drivers/iio/adc/max9611.c | 5 ++---
>> > 1 file changed, 2 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max9611.c
>> > index b1dd17c..ce0115a 100644
>> > --- a/drivers/iio/adc/max9611.c
>> > +++ b/drivers/iio/adc/max9611.c
>> > @@ -523,8 +523,7 @@ static const struct of_device_id max9611_of_table[] = {
>> > };
>> >
>> > MODULE_DEVICE_TABLE(of, max9611_of_table);
>> > -static int max9611_probe(struct i2c_client *client,
>> > - const struct i2c_device_id *id)
>> > +static int max9611_probe(struct i2c_client *client)
>> > {
>> > const char * const shunt_res_prop = "shunt-resistor-micro-ohms";
>> > const struct device_node *of_node = client->dev.of_node;
>> > @@ -576,7 +575,7 @@ static struct i2c_driver max9611_driver = {
>> > .owner = THIS_MODULE,
>> > .of_match_table = max9611_of_table,
>> > },
>> > - .probe = max9611_probe,
>> > + .probe_new = max9611_probe,
>> > };
>> > module_i2c_driver(max9611_driver);
>> >
>> > --
>> > 2.7.4
>> >
next prev parent reply other threads:[~2017-12-30 12:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 13:59 [PATCH v2] iio: adc: max9611: fix module auto-loading Dmitry Mastykin
2017-12-29 15:30 ` Andy Shevchenko
2017-12-29 17:54 ` Jonathan Cameron
2017-12-30 12:43 ` Dmitry Mastykin [this message]
2018-01-01 9:53 ` Jonathan Cameron
2018-01-03 12:41 ` Dmitry Mastykin
2018-01-06 13:14 ` Jonathan Cameron
2018-01-06 21:37 ` Dmitry Mastykin
2018-01-07 16:08 ` Jonathan Cameron
2018-01-09 11:07 ` Dmitry Mastykin
2018-01-10 3:51 ` Dmitry Mastykin
2018-01-10 11:03 ` Javier Martinez Canillas
2018-01-10 11:01 ` Javier Martinez Canillas
2018-01-14 10:51 ` Jonathan Cameron
2018-01-15 12:31 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALieaeeZXZ-6WKYXSMgLiiTO6eTFvdJjazOY9wx4VFk7YcA4Lg@mail.gmail.com \
--to=mastichi@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=jacopo+renesas@jmondi.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).