linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rui Salvaterra <rsalvaterra@gmail.com>
To: ming.lei@redhat.com
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Bug: swap discard issue with zram caused by "block: don't deal with discard limit in blkdev_issue_discard()"
Date: Sun, 28 Oct 2018 08:53:03 +0000	[thread overview]
Message-ID: <CALjTZvZtmTCvLQph95rNQk73L23h=1QaODny_ZOf9F1MjcsMFQ@mail.gmail.com> (raw)
In-Reply-To: <20181028010156.GB26731@ming.t460p>

On Sun, 28 Oct 2018 at 01:02, Ming Lei <ming.lei@redhat.com> wrote:
>
> On Fri, Oct 26, 2018 at 08:50:20AM +0100, Rui Salvaterra wrote:
> > On Fri, 26 Oct 2018 at 07:27, Ming Lei <ming.lei@redhat.com> wrote:
> > >
> > > The patch titled with 'block: make sure discard bio is aligned with logical block size'
> > > in the list may fix this issue, please test and see if it works.
> > >
> > > Thanks,
> > > Ming
> >
> > Hi, Ming,
> >
> > Thanks for the quick reply. Unfortunately, it doesn't seem to apply
> > cleanly to 4.19. To which tree/tag/commit should I apply the series?
>
> The whole patchset is against linus tree (44786880df196a4200).
>
> I am sure that the 1st patch can be applied cleanly against v4.19, and
> it is enough for fixing this issue, please double check.
>
> [ming@ming linux]$ git log --oneline -1
> 84df9525b0c2 Linux 4.19
> [ming@ming linux]$ git am ~/emails/blk/181026\ \[PATCH\ 1∕3\]\ block\:\ make\ sure\ discard\ bio\ is\ aligned\ with\ logical\ block\ size.eml
> Applying: block: make sure discard bio is aligned with logical block size
> [ming@ming linux]$
>
>
> Thanks,
> Ming

Hi, Ming,

You're, right, of course. I had reverted the aforementioned commit, so
the patch set obviously wouldn't apply anymore. After checking out
v4.19 again, everything went smoothly. I confirm the patch set fixes
the issue for me, which means this series is

Tested-by: Rui Salvaterra <rsalvaterra@gmail.com>

Thanks again,

Rui

      reply	other threads:[~2018-10-28  8:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-25 16:09 Bug: swap discard issue with zram caused by "block: don't deal with discard limit in blkdev_issue_discard()" Rui Salvaterra
2018-10-26  2:00 ` Ming Lei
2018-10-26  6:27 ` Ming Lei
2018-10-26  7:50   ` Rui Salvaterra
2018-10-28  1:01     ` Ming Lei
2018-10-28  8:53       ` Rui Salvaterra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALjTZvZtmTCvLQph95rNQk73L23h=1QaODny_ZOf9F1MjcsMFQ@mail.gmail.com' \
    --to=rsalvaterra@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).