From: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
To: Rob Herring <robh@kernel.org>
Cc: Ajye Huang <ajye.huang@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Patrick Lai <plai@codeaurora.org>,
Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Cheng-yi Chiang <cychiang@chromium.org>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH v5 1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case
Date: Fri, 6 Nov 2020 11:48:37 +0800 [thread overview]
Message-ID: <CALprXBYUddwE-+Bnt2qh4ETwZJ2LnwmB1mQNT88vcqxB8kPW4Q@mail.gmail.com> (raw)
In-Reply-To: <20201105184350.GA1611477@bogus>
HI, Rob,
Thank you for the comments.
On Fri, Nov 6, 2020 at 2:43 AM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Nov 03, 2020 at 06:30:50PM +0800, Ajye Huang wrote:
> > Add a property "dmic-gpios" for switching between two MICs.
> >
> > Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
> > ---
> > .../bindings/sound/google,sc7180-trogdor.yaml | 58 +++++++++++++++++++
> > 1 file changed, 58 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
> > index efc34689d6b5..9e0505467e57 100644
> > --- a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
> > +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
> > @@ -34,6 +34,9 @@ properties:
> > "#size-cells":
> > const: 0
> >
> > + dmic-gpios:
> > + description: GPIO for switching between DMICs
>
> Need to define how many (maxItems: 1).
Yes, I will add in the v6 version.
>
> > +
> > patternProperties:
> > "^dai-link(@[0-9])?$":
> > description:
> > @@ -81,6 +84,7 @@ additionalProperties: false
> > examples:
> >
> > - |
> > + //Example 1
> > sound {
> > compatible = "google,sc7180-trogdor";
> > model = "sc7180-rt5682-max98357a-1mic";
> > @@ -128,3 +132,57 @@ examples:
> > };
> > };
> > };
> > +
> > + - |
> > + //Example 2 (2mic case)
> > + sound {
> > + compatible = "google,sc7180-trogdor";
> > + model = "sc7180-rt5682-max98357a-2mic";
> > +
> > + audio-routing =
> > + "Headphone Jack", "HPOL",
> > + "Headphone Jack", "HPOR";
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + dmic-gpios = <&tlmm 86 0>;
>
> Do we really need another example for this? Can't you just add it to the
> existing example?
I think just keep One example. I will remove the example2 and put
dmic-gpios = <&tlmm 86 0>; in the first example and
modify the model from "sc7180-rt5682-max98357a-1mic" to
"sc7180-rt5682-max98357a-2mic". It looks clear.
>
> > +
> > + dai-link@0 {
> > + link-name = "MultiMedia0";
> > + reg = <0>;
> > + cpu {
> > + sound-dai = <&lpass_cpu 0>;
> > + };
> > +
> > + codec {
> > + sound-dai = <&alc5682 0>;
> > + };
> > + };
> > +
> > + dai-link@1 {
> > + link-name = "MultiMedia1";
> > + reg = <1>;
> > + cpu {
> > + sound-dai = <&lpass_cpu 1>;
> > + };
> > +
> > + codec {
> > + sound-dai = <&max98357a>;
> > + };
> > + };
> > +
> > + dai-link@2 {
> > + link-name = "MultiMedia2";
> > + reg = <2>;
> > + cpu {
> > + sound-dai = <&lpass_hdmi 0>;
> > + };
> > +
> > + codec {
> > + sound-dai = <&msm_dp>;
> > + };
> > + };
> > + };
> > +
> > +...
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2020-11-06 3:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 10:30 [PATCH v5 0/2] Modify documentation and machine driver for SC7180 sound card Ajye Huang
2020-11-03 10:30 ` [PATCH v5 1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case Ajye Huang
2020-11-03 10:36 ` Ajye Huang
2020-11-05 18:43 ` Rob Herring
2020-11-06 3:48 ` Ajye Huang [this message]
2020-11-03 10:30 ` [PATCH v5 2/2] ASoC: qcom: sc7180: Modify machine driver for 2mic Ajye Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALprXBYUddwE-+Bnt2qh4ETwZJ2LnwmB1mQNT88vcqxB8kPW4Q@mail.gmail.com \
--to=ajye_huang@compal.corp-partner.google.com \
--cc=agross@kernel.org \
--cc=ajye.huang@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@codeaurora.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).