From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4300C388F7 for ; Mon, 9 Nov 2020 13:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 738872068D for ; Mon, 9 Nov 2020 13:55:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="N94TB+YL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729972AbgKINzb (ORCPT ); Mon, 9 Nov 2020 08:55:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729320AbgKINz2 (ORCPT ); Mon, 9 Nov 2020 08:55:28 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 358EBC0613CF for ; Mon, 9 Nov 2020 05:55:27 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id y25so9486176lja.9 for ; Mon, 09 Nov 2020 05:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lqe5HrIHoZLKJYdgktbLvnJ7WzCQkZi69agPba5hbSs=; b=N94TB+YLkY2zbd2qs/JZiN2GasG9bvVVY4+qr0qm28m37JUwCxHLgcQhFLqdiwG6wP 36p80N800qtZO5Y5/54aZ3Ds3GAdrT9imWS8aZb8ep4LsnRqxn28rWQ0L4kka52r8KUG Y2WqlS12ZqNcQ/DS/XYF4A0rpu58FzeiaQhUG5lkWFp1nZDw4XW7skWOaX2w4Q67UGUV s40AMt4lrMVcsuOScsZYctM2DZ32eM3D7zQHgRHReNxiC06jnVgWx6g3kZ4JP9zfkx+S 5/PrEpERodbnK0pJW7+SRxRRp4I/b2YxzIp3RZBBGl+I+yAbWCR+Um/ECXQr4LTJ/X/9 eI2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lqe5HrIHoZLKJYdgktbLvnJ7WzCQkZi69agPba5hbSs=; b=n20PT1YVCOeBfU2o/3WoOPWtvhnYB/SwVfpICcMcD8eGwR/Ho+YCZGWmdzdLYXSVvE +jMEfFmUz+DdFKBJk/ZhO3mI9OjFwIjWLpobVhFFr3Qw94I7KxdJpkQx3hpBr2NYJCy/ v0q2/DKYOO51T2xzH0LmDhSJbFp2WZPH0ZZ7qArOZu2wkMnZHvccEfs9y9nAxyrSYlQc dMzvt4UV8jKKKb39jznXJ8FxTuoxakK4ah6eNfTfGQT8DRHzfEUh3kCOf0FNzyW7s662 isUW98wwH4emqcy52MrV2np9YUCARDrx/kfLX+UVQu4lfmGDn7h0mkWt8Q8GGNXgJ1HF mh4Q== X-Gm-Message-State: AOAM5300NUOzH61Y4FalDSD5szz99sw1C4ZkDj9ybHo7cK2EHBvWeYoT oPWHKLew4Irck+HQU4I6ympoxgTB1EtvWqyNaryuOEuS3OKsWI5C X-Google-Smtp-Source: ABdhPJz3iQtflkEPiWk1FMPU1/Pd2p7uJeOvrzUebarKW+NuNnCZ6Uh/UONYKo/x7LVUoyml/JF+BdvydSLnid3qOuA= X-Received: by 2002:a2e:b54a:: with SMTP id a10mr5875868ljn.139.1604930125511; Mon, 09 Nov 2020 05:55:25 -0800 (PST) MIME-Version: 1.0 References: <20201106061433.1483129-1-ajye_huang@compal.corp-partner.google.com> <20201106061433.1483129-2-ajye_huang@compal.corp-partner.google.com> In-Reply-To: <20201106061433.1483129-2-ajye_huang@compal.corp-partner.google.com> From: Ajye Huang Date: Mon, 9 Nov 2020 21:55:14 +0800 Message-ID: Subject: Re: [PATCH v6 1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case To: Ajye Huang Cc: Linux Kernel Mailing List , Mark Brown , Rohit kumar , Banajit Goswami , Patrick Lai , Srinivasa Rao Mandadapu , Srini Kandagatla , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Rob Herring , Jaroslav Kysela , Cheng-yi Chiang , Tzung-Bi Shih , Douglas Anderson , "moderated list:ARM/Mediatek SoC support" , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rob I follow your suggests that adding (maxItems: 1) for dmic-gpis property, and keep one example of adding dmic-gpios property in it Could you please kindly review it ? Thank you so much Ajye On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang wrote: > > Add a property "dmic-gpios" for switching between two MICs. > > Signed-off-by: Ajye Huang > --- > .../devicetree/bindings/sound/google,sc7180-trogdor.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > index efc34689d6b5..ce050a9dec94 100644 > --- a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml > @@ -34,6 +34,10 @@ properties: > "#size-cells": > const: 0 > > + dmic-gpios: > + maxItems: 1 > + description: GPIO for switching between DMICs > + > patternProperties: > "^dai-link(@[0-9])?$": > description: > @@ -83,7 +87,7 @@ examples: > - | > sound { > compatible = "google,sc7180-trogdor"; > - model = "sc7180-rt5682-max98357a-1mic"; > + model = "sc7180-rt5682-max98357a-2mic"; > > audio-routing = > "Headphone Jack", "HPOL", > @@ -92,6 +96,8 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > > + dmic-gpios = <&tlmm 86 0>; > + > dai-link@0 { > link-name = "MultiMedia0"; > reg = <0>; > -- > 2.25.1 >