From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbdCBW0u (ORCPT ); Thu, 2 Mar 2017 17:26:50 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:32892 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbdCBW0s (ORCPT ); Thu, 2 Mar 2017 17:26:48 -0500 MIME-Version: 1.0 In-Reply-To: References: <1488489544-25941-1-git-send-email-singhalsimran0@gmail.com> <1488489544-25941-4-git-send-email-singhalsimran0@gmail.com> From: SIMRAN SINGHAL Date: Fri, 3 Mar 2017 03:28:01 +0530 Message-ID: Subject: Re: [Outreachy kernel] [PATCH 4/5] staging: rts5208: Remove unnecessary cast on void pointer To: Julia Lawall Cc: Larry.Finger@lwfinger.net, Florian Schilhabel , Greg KH , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, oleg.drokin@intel.com, marvin24@gmx.de, outreachy-kernel@googlegroups.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 3, 2017 at 3:26 AM, Julia Lawall wrote: >> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c >> index 2379901..d745b93 100644 >> --- a/drivers/staging/rts5208/rtsx_transport.c >> +++ b/drivers/staging/rts5208/rtsx_transport.c >> @@ -767,7 +767,7 @@ int rtsx_transfer_data(struct rtsx_chip *chip, u8 card, void *buf, size_t len, >> >> if (use_sg) { >> err = rtsx_transfer_sglist_adma(chip, card, >> - (struct scatterlist *)buf, >> + buf, > > Here too, buf doesn't need its own line. > I will send v2. > julia > >> use_sg, dma_dir, timeout); >> } else { >> err = rtsx_transfer_buf(chip, card, buf, len, dma_dir, timeout); >> -- >> 2.7.4 >> >> -- >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. >> To post to this group, send email to outreachy-kernel@googlegroups.com. >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488489544-25941-4-git-send-email-singhalsimran0%40gmail.com. >> For more options, visit https://groups.google.com/d/optout. >>