From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751985AbdCCQey (ORCPT ); Fri, 3 Mar 2017 11:34:54 -0500 Received: from mail-lf0-f51.google.com ([209.85.215.51]:35827 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751744AbdCCQeh (ORCPT ); Fri, 3 Mar 2017 11:34:37 -0500 MIME-Version: 1.0 In-Reply-To: <1488556204.2179.32.camel@perches.com> References: <1488540925-16898-1-git-send-email-singhalsimran0@gmail.com> <1488556204.2179.32.camel@perches.com> From: SIMRAN SINGHAL Date: Fri, 3 Mar 2017 21:35:55 +0530 Message-ID: Subject: Re: [PATCH v3 0/5] Fixed compilation error To: Joe Perches Cc: Larry.Finger@lwfinger.net, Florian Schilhabel , Greg KH , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, oleg.drokin@intel.com, marvin24@gmx.de, outreachy-kernel@googlegroups.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v23GZH6U005975 On Fri, Mar 3, 2017 at 9:20 PM, Joe Perches wrote: > On Fri, 2017-03-03 at 17:05 +0530, simran singhal wrote: >> Fixed compilation warning in lustre/lustre/llite/range_lock.c > > Really? What compilation warning was removed? CC [M] drivers/staging/lustre/lustre/mgc/mgc_request.o drivers/staging/lustre/lustre/mgc/mgc_request.c: In function ‘mgc_set_info_async’: drivers/staging/lustre/lustre/mgc/mgc_request.c:1036:115: warning: format ‘%s’ expects argument of type ‘char *’, but argument 3 has type ‘void *’ [-Wformat=] I was getting this warning because of changing (char *)val to val where val is a pointer to void. So I fixed this by reverting this change. Simran > >> simran singhal (5): >> staging: nvec: Remove unnecessary cast on void pointer >> staging: lustre: Remove unnecessary cast on void pointer >> staging: lustre: lustre: Remove unnecessary cast on void pointer >> staging: rts5208: Remove unnecessary cast on void pointer >> staging: rtl8712: Remove unnecessary cast on void pointer > > What compiler warns about unnecessary casts? > >> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +- >> drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- >> drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- >> drivers/staging/nvec/nvec_kbd.c | 2 +- >> drivers/staging/rtl8712/rtl8712_recv.c | 11 +++++------ >> drivers/staging/rts5208/rtsx_transport.c | 3 +-- >> 6 files changed, 11 insertions(+), 13 deletions(-) >>