From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751617AbdCBWC2 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 2 Mar 2017 17:02:28 -0500
Received: from mail-lf0-f49.google.com ([209.85.215.49]:34457 "EHLO
        mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751558AbdCBWCZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 2 Mar 2017 17:02:25 -0500
MIME-Version: 1.0
In-Reply-To: <1488491006.2179.14.camel@perches.com>
References: <1488489544-25941-1-git-send-email-singhalsimran0@gmail.com>
 <1488489544-25941-3-git-send-email-singhalsimran0@gmail.com> <1488491006.2179.14.camel@perches.com>
From: SIMRAN SINGHAL <singhalsimran0@gmail.com>
Date: Fri, 3 Mar 2017 03:25:26 +0530
Message-ID: <CALrZqyN3si-5v5PLWc9ppQ7CjqZGXAXU02GrnyspsioStKTWng@mail.gmail.com>
Subject: Re: [PATCH 3/5] staging: lustre: lustre: Remove unnecessary cast on
 void pointer
To: Joe Perches <joe@perches.com>
Cc: Larry.Finger@lwfinger.net,
        Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
        Greg KH <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, oleg.drokin@intel.com, marvin24@gmx.de,
        outreachy-kernel@googlegroups.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 3, 2017 at 3:13 AM, Joe Perches <joe@perches.com> wrote:
> On Fri, 2017-03-03 at 02:49 +0530, simran singhal wrote:
>> The following Coccinelle script was used to detect this:
>> @r@
>> expression x;
>> void* e;
>> type T;
>> identifier f;
>> @@
>> (
>>   *((T *)e)
>> >
>>
>>   ((T *)x)[...]
>> >
>>
>>   ((T*)x)->f
>> >
>>
>> - (T*)
>>   e
>> )
>
> NAK.
>
> Nice, but you still have to verify correctness
> before submitting these patches.
>
>> diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
> []
>> @@ -1034,7 +1034,7 @@ static int mgc_set_info_async(const struct lu_env *env, struct obd_export *exp,
>>               rc = sptlrpc_parse_flavor(val, &flvr);
>>               if (rc) {
>>                       CERROR("invalid sptlrpc flavor %s to MGS\n",
>> -                            (char *)val);
>> +                            val);
>
> Try compiling this.
>

I compiled it before sending.