From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932611AbcFTLdZ (ORCPT ); Mon, 20 Jun 2016 07:33:25 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:34325 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbcFTLdQ (ORCPT ); Mon, 20 Jun 2016 07:33:16 -0400 MIME-Version: 1.0 In-Reply-To: <1466112442-31105-48-git-send-email-daniel.lezcano@linaro.org> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-48-git-send-email-daniel.lezcano@linaro.org> From: Maxime Coquelin Date: Mon, 20 Jun 2016 13:32:15 +0200 Message-ID: Subject: Re: [PATCH V2 47/63] clocksource/drivers/timer-stm32: Convert init function to return error To: Daniel Lezcano Cc: Thomas Gleixner , "linux-kernel@vger.kernel.org" , "moderated list:ARM/STM32 ARCHITE..." Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-06-16 23:27 GMT+02:00 Daniel Lezcano : > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/timer-stm32.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime