From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9B4C433DF for ; Sun, 18 Oct 2020 15:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F036E20714 for ; Sun, 18 Oct 2020 15:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="mOxpLHHY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727040AbgJRPGo (ORCPT ); Sun, 18 Oct 2020 11:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbgJRPGn (ORCPT ); Sun, 18 Oct 2020 11:06:43 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB528C0613CE for ; Sun, 18 Oct 2020 08:06:41 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id q9so9997818iow.6 for ; Sun, 18 Oct 2020 08:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=czqkN2JOMIdx3mElJVahK+RV1sW2EcADLO8fEOnd2gY=; b=mOxpLHHYKQ/9MAts3WpueP7YGC5Tun1HFH3VKXZgKDwJK1H36gxsO4ubHorxcqk1oc pbE0aAnvFYngbcN/jByjxx71P5QnOjcvW22dCVU6o6w29DPkIDCqXu9LnrnfVI0CfHzo ThxPLd4aZ1zjFG/yqPXPDnWfAaG/Ulrt1Gy6syHznLnTjHI/13M+JDsaKOvSD8bg5qXL /OhfNQjW1bDxLB5n4MS74dYPqSeKtcRTqoMi2WF2wTTv63C2mMk4OwZP9h1G96rfxq77 lxQCWZLyPrUzkz11xv1d5gQNJTW/CFhZr8IDTxmVyC15fdjWpAx2qHmouOgHLoyDY18L Qm7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=czqkN2JOMIdx3mElJVahK+RV1sW2EcADLO8fEOnd2gY=; b=gjjsS4WI7sfrVeANVS+hVv+TmtoxFY9VaK3inyoe9Nij2gULcJF4Dhx7+tf43/7KKq SHXXIW8YuK9oimlkbjA5NxAAN0oo769cXIQHzofLNPTzvshRmUYzxGaPFtdHzOU2TIwQ TW+P2zwfPsNqLTvCvCDvx1D2ncWXOFPWE5jG++vsIMQ9DYTq6BPPMa8EWDpNd84fMUg9 yVKJ2yF6L7638Im5e+Ciu82+bpES52qSsvDYWoxRA6mZgcbeW43iJCGv4wwrfRslKA4r MXVAmm7Zj8n5vmQEgvR/lYdjTIwHrUAhvD9ip1zqiaNagQV2c26WwyeTXMkNPvnjQw/A w3/g== X-Gm-Message-State: AOAM532YoDkr2DZPCgWBkdI+KV9EycdTdkXIAIINhlVTGNa5LnMXpRms z1yOIs6JfGUqNuz0PUgW7YpD5u3GWjXXRtXJ0Cz+6rDNwhs9qDc= X-Google-Smtp-Source: ABdhPJxTmtCnVTbI2p+LMLIuIbMjWoDpTYT8mP5zpcvmq/R2e4Cp3/i29Cz0eVW2BcFfRfCP2mOKgFfx3h9Yw2dcZO4= X-Received: by 2002:a6b:b208:: with SMTP id b8mr8121415iof.36.1603033601269; Sun, 18 Oct 2020 08:06:41 -0700 (PDT) MIME-Version: 1.0 References: <20201018033602.GA27912@ubuntu> <20201018123651.635e2ec3@archlinux> In-Reply-To: <20201018123651.635e2ec3@archlinux> From: Vaishnav M A Date: Sun, 18 Oct 2020 20:36:30 +0530 Message-ID: Subject: Re: [PATCH v2] iio: light: vcnl4035 add i2c_device_id To: Jonathan Cameron Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Alexandru Ardelean , "open list:IIO SUBSYSTEM AND DRIVERS" , open list , Jason Kridner , Drew Fustini , Robert Nelson , =?UTF-8?Q?Ivan_Rajkovi=C4=87?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 18, 2020 at 5:06 PM Jonathan Cameron wrote: > > On Sun, 18 Oct 2020 09:06:02 +0530 > Vaishnav M A wrote: > > > add i2c_device_id for the vcnl4035 driver so that > > the device can be instantiated using i2c_new_client_device > > or from userspace, useful in cases where device tree based > > description is not possible now(Eg. a device on a gbphy i2c > > adapter created by greybus) > > > > Signed-off-by: Vaishnav M A > Rewrite the description and this should be fine. > > Thanks, > > Jonathan > Thank you Jonathan for the Review, I have submitted v3 patch with the modified description: https://lore.kernel.org/patchwork/patch/1322195/ Thanks, Vaishnav > > --- > > v2: > > - fix commit message > > drivers/iio/light/vcnl4035.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/iio/light/vcnl4035.c b/drivers/iio/light/vcnl4035.c > > index 765c44adac57..73a28e30dddc 100644 > > --- a/drivers/iio/light/vcnl4035.c > > +++ b/drivers/iio/light/vcnl4035.c > > @@ -652,6 +652,12 @@ static const struct dev_pm_ops vcnl4035_pm_ops = { > > vcnl4035_runtime_resume, NULL) > > }; > > > > +static const struct i2c_device_id vcnl4035_id[] = { > > + { "vcnl4035", 0}, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(i2c, vcnl4035_id); > > + > > static const struct of_device_id vcnl4035_of_match[] = { > > { .compatible = "vishay,vcnl4035", }, > > { } > > @@ -666,6 +672,7 @@ static struct i2c_driver vcnl4035_driver = { > > }, > > .probe = vcnl4035_probe, > > .remove = vcnl4035_remove, > > + .id_table = vcnl4035_id, > > }; > > > > module_i2c_driver(vcnl4035_driver); >