From: Shakeel Butt <shakeelb@google.com>
To: Hui Zhu <teawaterz@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Dan Streetman <ddstreet@ieee.org>,
Minchan Kim <minchan@kernel.org>,
ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
Seth Jennings <sjenning@redhat.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] zpool: Add malloc_support_movable to zpool_driver
Date: Wed, 10 Jul 2019 11:20:29 -0700 [thread overview]
Message-ID: <CALvZod45JPt_89GRzpWyuxSJHtNQSiweR2-dh+hpbTBi1EbPWw@mail.gmail.com> (raw)
In-Reply-To: <20190605100630.13293-1-teawaterz@linux.alibaba.com>
Cc: akpm@linux-foundation.org
On Wed, Jun 5, 2019 at 3:06 AM Hui Zhu <teawaterz@linux.alibaba.com> wrote:
>
> As a zpool_driver, zsmalloc can allocate movable memory because it
> support migate pages.
> But zbud and z3fold cannot allocate movable memory.
>
> This commit adds malloc_support_movable to zpool_driver.
> If a zpool_driver support allocate movable memory, set it to true.
> And add zpool_malloc_support_movable check malloc_support_movable
> to make sure if a zpool support allocate movable memory.
>
> Signed-off-by: Hui Zhu <teawaterz@linux.alibaba.com>
I was wondering why this patch is not picked up by Andrew yet. You
forgot to CC Andrew.
Andrew, the thread starts at:
http://lkml.kernel.org/r/20190605100630.13293-1-teawaterz@linux.alibaba.com
> ---
> include/linux/zpool.h | 3 +++
> mm/zpool.c | 16 ++++++++++++++++
> mm/zsmalloc.c | 19 ++++++++++---------
> 3 files changed, 29 insertions(+), 9 deletions(-)
>
> diff --git a/include/linux/zpool.h b/include/linux/zpool.h
> index 7238865e75b0..51bf43076165 100644
> --- a/include/linux/zpool.h
> +++ b/include/linux/zpool.h
> @@ -46,6 +46,8 @@ const char *zpool_get_type(struct zpool *pool);
>
> void zpool_destroy_pool(struct zpool *pool);
>
> +bool zpool_malloc_support_movable(struct zpool *pool);
> +
> int zpool_malloc(struct zpool *pool, size_t size, gfp_t gfp,
> unsigned long *handle);
>
> @@ -90,6 +92,7 @@ struct zpool_driver {
> struct zpool *zpool);
> void (*destroy)(void *pool);
>
> + bool malloc_support_movable;
> int (*malloc)(void *pool, size_t size, gfp_t gfp,
> unsigned long *handle);
> void (*free)(void *pool, unsigned long handle);
> diff --git a/mm/zpool.c b/mm/zpool.c
> index a2dd9107857d..863669212070 100644
> --- a/mm/zpool.c
> +++ b/mm/zpool.c
> @@ -238,6 +238,22 @@ const char *zpool_get_type(struct zpool *zpool)
> return zpool->driver->type;
> }
>
> +/**
> + * zpool_malloc_support_movable() - Check if the zpool support
> + * allocate movable memory
> + * @zpool: The zpool to check
> + *
> + * This returns if the zpool support allocate movable memory.
> + *
> + * Implementations must guarantee this to be thread-safe.
> + *
> + * Returns: true if if the zpool support allocate movable memory, false if not
> + */
> +bool zpool_malloc_support_movable(struct zpool *zpool)
> +{
> + return zpool->driver->malloc_support_movable;
> +}
> +
> /**
> * zpool_malloc() - Allocate memory
> * @zpool: The zpool to allocate from.
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 0787d33b80d8..8f3d9a4d46f4 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -437,15 +437,16 @@ static u64 zs_zpool_total_size(void *pool)
> }
>
> static struct zpool_driver zs_zpool_driver = {
> - .type = "zsmalloc",
> - .owner = THIS_MODULE,
> - .create = zs_zpool_create,
> - .destroy = zs_zpool_destroy,
> - .malloc = zs_zpool_malloc,
> - .free = zs_zpool_free,
> - .map = zs_zpool_map,
> - .unmap = zs_zpool_unmap,
> - .total_size = zs_zpool_total_size,
> + .type = "zsmalloc",
> + .owner = THIS_MODULE,
> + .create = zs_zpool_create,
> + .destroy = zs_zpool_destroy,
> + .malloc_support_movable = true,
> + .malloc = zs_zpool_malloc,
> + .free = zs_zpool_free,
> + .map = zs_zpool_map,
> + .unmap = zs_zpool_unmap,
> + .total_size = zs_zpool_total_size,
> };
>
> MODULE_ALIAS("zpool-zsmalloc");
> --
> 2.21.0 (Apple Git-120)
>
prev parent reply other threads:[~2019-07-10 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 10:06 [PATCH V3 1/2] zpool: Add malloc_support_movable to zpool_driver Hui Zhu
2019-06-05 10:06 ` [PATCH V3 2/2] zswap: Use movable memory if zpool support allocate movable memory Hui Zhu
2019-06-05 19:53 ` Shakeel Butt
2019-07-10 18:29 ` Shakeel Butt
2019-06-05 16:31 ` [PATCH V3 1/2] zpool: Add malloc_support_movable to zpool_driver Shakeel Butt
2019-06-06 0:23 ` Vitaly Wool
2019-06-05 19:56 ` Shakeel Butt
2019-07-10 18:20 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod45JPt_89GRzpWyuxSJHtNQSiweR2-dh+hpbTBi1EbPWw@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sjenning@redhat.com \
--cc=teawaterz@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).