linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shakeel Butt <shakeelb@google.com>
To: "wanghai (M)" <wanghai38@huawei.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
	Michal Hocko <mhocko@suse.com>, Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/memcg: fix NULL pointer dereference in memcg_slab_free_hook()
Date: Wed, 28 Jul 2021 07:44:14 -0700	[thread overview]
Message-ID: <CALvZod4G8XrxoHhyJcUKxtbKSLKUFwLWb8_50Ed6j1-3hn1WVA@mail.gmail.com> (raw)
In-Reply-To: <aced9cfe-2ae4-b717-62f5-e495ca4934c2@huawei.com>

On Wed, Jul 28, 2021 at 7:34 AM wanghai (M) <wanghai38@huawei.com> wrote:
>
>
> 在 2021/7/28 22:26, Shakeel Butt 写道:
> > On Wed, Jul 28, 2021 at 7:21 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> >>
> >> On 2021/7/28 21:23, Michal Hocko wrote:
> >>> On Wed 28-07-21 17:13:48, Wang Hai wrote:
> >>>> When I use kfree_rcu() to free a large memory allocated by
> >>>> kmalloc_node(), the following dump occurs.
> >>>>
> >>>> BUG: kernel NULL pointer dereference, address: 0000000000000020
> >>>> [...]
> >>>> Oops: 0000 [#1] SMP
> >>>> [...]
> >>>> Workqueue: events kfree_rcu_work
> >>>> RIP: 0010:__obj_to_index include/linux/slub_def.h:182 [inline]
> >>>> RIP: 0010:obj_to_index include/linux/slub_def.h:191 [inline]
> >>>> RIP: 0010:memcg_slab_free_hook+0x120/0x260 mm/slab.h:363
> >>>> [...]
> >>>> Call Trace:
> >>>>    kmem_cache_free_bulk+0x58/0x630 mm/slub.c:3293
> >>>>    kfree_bulk include/linux/slab.h:413 [inline]
> >>>>    kfree_rcu_work+0x1ab/0x200 kernel/rcu/tree.c:3300
> >>>>    process_one_work+0x207/0x530 kernel/workqueue.c:2276
> >>>>    worker_thread+0x320/0x610 kernel/workqueue.c:2422
> >>>>    kthread+0x13d/0x160 kernel/kthread.c:313
> >>>>    ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
> >>>>
> >>>> When kmalloc_node() a large memory, page is allocated, not slab,
> >>>> so when freeing memory via kfree_rcu(), this large memory should not
> >>>> be used by memcg_slab_free_hook(), because memcg_slab_free_hook() is
> >>>> is used for slab.
> >>>>
> >>>> So in this case, there is no need to do anything with this large
> >>>> page in memcg_slab_free_hook(), just skip it.
> >>>>
> >>>> Fixes: 270c6a71460e ("mm: memcontrol/slab: Use helpers to access slab page's memcg_data")
> >>> Are you sure that this commit is really breaking the code. Unless I have
> >> Yes, we confirmed that this commit introduces the bug.
> >>> missed something there shouldn't be any real change wrt. large
> >>> allocations here. page_has_obj_cgroups is just a different name for what
> >>> what page_objcgs is giving us.
> >> maybe we could simply use page_objcgs_check to fix the issue ? we will
> >> check it again.
> > You will see the same crash with page_objcgs_check as well.
> > .
>
> I just test it. It won't crash.
>
> This is the test case:
>
> node = kmalloc_node(299999, GFP_ATOMIC | __GFP_NOWARN | __GFP_ACCOUNT, -1);
> kfree_rcu(node, rcu);
>

Indeed it is checking MEMCG_DATA_OBJCGS directly. Yeah, we can use
page_objcgs_check(). Please send a new version of the patch and do CC
Roman.

      reply	other threads:[~2021-07-28 14:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28  9:13 Wang Hai
2021-07-28 10:49 ` Kefeng Wang
2021-07-28 13:23 ` Michal Hocko
2021-07-28 14:10   ` Shakeel Butt
2021-07-28 16:43     ` Michal Hocko
2021-07-28 14:21   ` Kefeng Wang
2021-07-28 14:26     ` Shakeel Butt
2021-07-28 14:33       ` wanghai (M)
2021-07-28 14:44         ` Shakeel Butt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALvZod4G8XrxoHhyJcUKxtbKSLKUFwLWb8_50Ed6j1-3hn1WVA@mail.gmail.com \
    --to=shakeelb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=ast@kernel.org \
    --cc=cl@linux.com \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=wanghai38@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    --subject='Re: [PATCH] mm/memcg: fix NULL pointer dereference in memcg_slab_free_hook()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).