From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4977C433ED for ; Tue, 13 Apr 2021 14:19:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D9EB60FE8 for ; Tue, 13 Apr 2021 14:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230028AbhDMOTe (ORCPT ); Tue, 13 Apr 2021 10:19:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhDMOT2 (ORCPT ); Tue, 13 Apr 2021 10:19:28 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E081C061574 for ; Tue, 13 Apr 2021 07:19:08 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id f41so4244121lfv.8 for ; Tue, 13 Apr 2021 07:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z8E4aJWY8S1UewlX1deTBL/TSfNjGfLKOGHhOfD8DdQ=; b=wNEgu565JVChQOzqfu7VI4YMq9rsnsx91xg5exzQG4fW8BhPE9txEfAZNQXtJ6eguF QcePnkqE22FvS6FaytPrXYAvwp+kIPYuMuVwkzo1GEHTG0Mt4xLqwioGDVoAZtl/i/pr NgAjV893s9/nqObtXpgFP4Sv0Qdp1kMqwhW/mtN6B94EEWGF4NBz13U+VkDE4HjwnTGM jbLe73Brwf75Jqml/0fYWnXJ1AXfBALl/98zgVDvMrrXTC0DKS22seqxXgqd+sb3Ydma vT6OKSqnzY25RF9UmXy2rH2rymrl/4D+WPiTzf8M4SH1Q0bbr6THv5ALayWkD+XCzjzV oZyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z8E4aJWY8S1UewlX1deTBL/TSfNjGfLKOGHhOfD8DdQ=; b=cTV9vorF0TBgXsFh5gsnJLIe9y3LRdqo7Xk8BXNXpQ3qpo/wmM6e8gunQX8/goBwaj GKyuucFqUyQ/T45DBRD58N94/Tk7Arc5UOL+zYEPde/V98RAlk7pkMHWb9i2ie7Ny6DG ugpgsIjU9tztrmNaEv5t2P44Tf6NC1iqet2rADYvU1b6IfzFMNKprCcSIvkc9fPKFCEr qy93brESMZYg0OxCyCn7ddLSCMREt9GN7pHU1BgSQ6bZ457IrN6jF1UzLRfYXbFPR0m5 RvBE3p8LGIeD4GKzOpCwqJkS75XF77uPapvPl0y4mf4bwStkU6f80Sqb5Wi1iWGl1aaG /8Rw== X-Gm-Message-State: AOAM532N6zoUGjmv9T5qqCWblWRK1Gmh/OViN28vRbnq6awc4Xe9DKiK 76wC6ZwevdtW4I4dBbjTSio1T0F6hrKqzRjYTCUP5w== X-Google-Smtp-Source: ABdhPJwxZXtINdMaf/cXfQkq4pbXsql3edDM43KiHd6FR2T4DmVGitIeVDELJNQp3WMnFtH1pMN1ymZ7b5Rc0vq4I5Y= X-Received: by 2002:ac2:546c:: with SMTP id e12mr8204910lfn.299.1618323545033; Tue, 13 Apr 2021 07:19:05 -0700 (PDT) MIME-Version: 1.0 References: <20210413065153.63431-1-songmuchun@bytedance.com> <20210413065153.63431-7-songmuchun@bytedance.com> In-Reply-To: <20210413065153.63431-7-songmuchun@bytedance.com> From: Shakeel Butt Date: Tue, 13 Apr 2021 07:18:52 -0700 Message-ID: Subject: Re: [PATCH 6/7] mm: memcontrol: move obj_cgroup_uncharge_pages() out of css_set_lock To: Muchun Song Cc: Roman Gushchin , Johannes Weiner , Michal Hocko , Andrew Morton , Vladimir Davydov , LKML , Linux MM , Xiongchun duan , fam.zheng@bytedance.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 11:58 PM Muchun Song wrote: > > The css_set_lock is used to guard the list of inherited objcgs. So there > is no need to uncharge kernel memory under css_set_lock. Just move it > out of the lock. > > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt