From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78008C432BE for ; Wed, 4 Aug 2021 22:59:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 608866104F for ; Wed, 4 Aug 2021 22:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233252AbhHDXAF (ORCPT ); Wed, 4 Aug 2021 19:00:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbhHDXAD (ORCPT ); Wed, 4 Aug 2021 19:00:03 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55092C0613D5 for ; Wed, 4 Aug 2021 15:59:49 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id z2so7298771lft.1 for ; Wed, 04 Aug 2021 15:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yKBCddFUD4ZVg3evBH79AytFMC59ICl5HYXSEir7plU=; b=ebulXj+Z6/Ub9Krg3pAiSomWCFfnFE/iXQaNP7ubYVZykn93fMeXr1/xIqFRinj3Ew GHG0ZtsMBZ3vsbi1bV89yG7QxskFZE9zwNBwqkrEAOoJJUVnzDtdJsNT2+45YXIs3Zix 1CTFZIkW9Qr7PMfu0rJP0gTAu9mb4U52cMdey1lgVR2VdwunvqUNyP3NVzTRvl/pfFaJ P8J6dtw+mEIbLeQ6+dklxX/a5k1orE/BdNeGeIfsvf/RA7EXcWQgWbvdJWHCRgPnQPYJ 8AF8Gtsv0G12SRSlrSWkKWhPVVMYwIUtwxD4yfRVyZgjFmcAU9cXYjfvghjjixLO60CZ Rmsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yKBCddFUD4ZVg3evBH79AytFMC59ICl5HYXSEir7plU=; b=DFTXvV6ec/CG57TNy5bV1O64y7zPE3xBn8WX+IBSbxPzcbeq5NLm50A3eFH8Ilc8PF fJHYbH5Xi/szp+69R5xiHMPyQ4hdgC0fricQmsBS9bp/ifDwNhe+eowIzf8wW8pdIXrR 7TrjnM2HBD94M7XB6sUeZMXqTA2WH4KOwDGBvxTD8QFvN9oDua5tNO1/Anvn+b8Vm511 YY5WFcuDzog6DOa9TiAT3GPNhT3Ktid2+SlqICdCPnLrQT+pClYhSfqjtAsVKzMuktIo j7+zxleOl6G6v8f0OF1jU/17iResi/EhhqE29uE3lVEF6hZ8ttm2lVoOmX+r9D8wXysd bGGA== X-Gm-Message-State: AOAM530wRujm4lwBtlt1/5fwtOMA4qP+l3hgLkDk5msrottJdIgzRGAP 4nBOO5nre7cXrVElhQZK4FpJzykHjx9utcdlsznqGQ== X-Google-Smtp-Source: ABdhPJxTwTEidem65WeqdTi/dr8QkeyuaN9y+ifYH6uanXfbyxom6MSKvxOnh5EKy7wfDzYDsvtUpyai4/S+yITO06k= X-Received: by 2002:a05:6512:c23:: with SMTP id z35mr1101321lfu.299.1628117987480; Wed, 04 Aug 2021 15:59:47 -0700 (PDT) MIME-Version: 1.0 References: <20210804185004.1304692-1-surenb@google.com> In-Reply-To: <20210804185004.1304692-1-surenb@google.com> From: Shakeel Butt Date: Wed, 4 Aug 2021 15:59:36 -0700 Message-ID: Subject: Re: [PATCH v6 1/2] mm: introduce process_mrelease system call To: Suren Baghdasaryan Cc: Andrew Morton , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , David Hildenbrand , Jann Horn , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , Linux MM , LKML , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 4, 2021 at 11:50 AM Suren Baghdasaryan wrote: > > In modern systems it's not unusual to have a system component monitoring > memory conditions of the system and tasked with keeping system memory > pressure under control. One way to accomplish that is to kill > non-essential processes to free up memory for more important ones. > Examples of this are Facebook's OOM killer daemon called oomd and > Android's low memory killer daemon called lmkd. > For such system component it's important to be able to free memory > quickly and efficiently. Unfortunately the time process takes to free > up its memory after receiving a SIGKILL might vary based on the state > of the process (uninterruptible sleep), size and OPP level of the core > the process is running. A mechanism to free resources of the target > process in a more predictable way would improve system's ability to > control its memory pressure. > Introduce process_mrelease system call that releases memory of a dying > process from the context of the caller. This way the memory is freed in > a more controllable way with CPU affinity and priority of the caller. > The workload of freeing the memory will also be charged to the caller. > The operation is allowed only on a dying process. > > After previous discussions [1, 2, 3] the decision was made [4] to introduce > a dedicated system call to cover this use case. > > The API is as follows, > > int process_mrelease(int pidfd, unsigned int flags); > > DESCRIPTION > The process_mrelease() system call is used to free the memory of > an exiting process. > > The pidfd selects the process referred to by the PID file > descriptor. > (See pidofd_open(2) for further information) > > The flags argument is reserved for future use; currently, this > argument must be specified as 0. > > RETURN VALUE > On success, process_mrelease() returns 0. On error, -1 is > returned and errno is set to indicate the error. > > ERRORS > EBADF pidfd is not a valid PID file descriptor. > > EAGAIN Failed to release part of the address space. > > EINTR The call was interrupted by a signal; see signal(7). > > EINVAL flags is not 0. > > EINVAL The memory of the task cannot be released because the > process is not exiting, the address space is shared > with another live process or there is a core dump in > progress. > > ENOSYS This system call is not supported, for example, without > MMU support built into Linux. > > ESRCH The target process does not exist (i.e., it has terminated > and been waited on). > > [1] https://lore.kernel.org/lkml/20190411014353.113252-3-surenb@google.com/ > [2] https://lore.kernel.org/linux-api/20201113173448.1863419-1-surenb@google.com/ > [3] https://lore.kernel.org/linux-api/20201124053943.1684874-3-surenb@google.com/ > [4] https://lore.kernel.org/linux-api/20201223075712.GA4719@lst.de/ > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt Next I wanna see cgroup.procs giving me pidfds.