From: Shakeel Butt <shakeelb@google.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] inotify, memcg: account inotify instances to kmemcg
Date: Sun, 20 Dec 2020 09:56:42 -0800 [thread overview]
Message-ID: <CALvZod4oTAysAqW9aotPgx1Qx+aL91LEiR5OiMt27=e3VJ6aVQ@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxi4b-zXfWhLNQ+aGWn2qG3vqMCjkJnhrugc0+oER1EjUA@mail.gmail.com>
On Sun, Dec 20, 2020 at 3:32 AM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Sun, Dec 20, 2020 at 6:46 AM Shakeel Butt <shakeelb@google.com> wrote:
> >
> > Currently the fs sysctl inotify/max_user_instances is used to limit the
> > number of inotify instances on the system. For systems running multiple
> > workloads, the per-user namespace sysctl max_inotify_instances can be
> > used to further partition inotify instances. However there is no easy
> > way to set a sensible system level max limit on inotify instances and
> > further partition it between the workloads. It is much easier to charge
> > the underlying resource (i.e. memory) behind the inotify instances to
> > the memcg of the workload and let their memory limits limit the number
> > of inotify instances they can create.
> >
> > With inotify instances charged to memcg, the admin can simply set
> > max_user_instances to INT_MAX and let the memcg limits of the jobs limit
> > their inotify instances.
> >
> > Signed-off-by: Shakeel Butt <shakeelb@google.com>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Thanks a lot.
next prev parent reply other threads:[~2020-12-20 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 4:46 [PATCH v2] inotify, memcg: account inotify instances to kmemcg Shakeel Butt
2020-12-20 11:32 ` Amir Goldstein
2020-12-20 17:56 ` Shakeel Butt [this message]
2020-12-21 10:44 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod4oTAysAqW9aotPgx1Qx+aL91LEiR5OiMt27=e3VJ6aVQ@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).