From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68693C4332E for ; Tue, 12 Jan 2021 22:00:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E0DF221FF for ; Tue, 12 Jan 2021 22:00:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393796AbhALWAi (ORCPT ); Tue, 12 Jan 2021 17:00:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727923AbhALWAd (ORCPT ); Tue, 12 Jan 2021 17:00:33 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6496FC061575 for ; Tue, 12 Jan 2021 13:59:52 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id n11so245022lji.5 for ; Tue, 12 Jan 2021 13:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=cRHFA4C63ztEV2JIf4LFaqF2zxgUQvb3Q0QPA2iOSY0=; b=RyKM/ND3OaSVjkewh9Fz3AQZXonM2KCrQo2i2xQPD3+dds2gbnnFqCY3dlrSwf5xx+ iiF4spDbAWiHN22NB2K/mxe+kjS4Amic4Fnmk0LtF/HoEWwxbzj364eAnihFkBCdIqs2 QbpinVaXb3uaeQIhBuYjhQGRbMfXWaOZr0dSIM37n7VUUxN0xM7F1QStS1HKvxD6EuWV AmFsPkboTVYPH/QKW/NesXcOyXBIoOqbZwjarRsExLdJHcOXnA2X1j0g62f45OoFrV8D KqMkIPesv5wGRUEfRf1zL1Pz66VdVS9MtdS7enJ/0GzAt7jz1vF/efcwuJlMJz5Dvexi JNyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=cRHFA4C63ztEV2JIf4LFaqF2zxgUQvb3Q0QPA2iOSY0=; b=rfHyrcZ9MUQGOiDNE1zP8ZsXds4VPt2i5z1n2kOWtAdOdGHJxqWYlyKTvcnt/b+46X ic7bJlE9UJKFo/eK5tP0xqG3647UNRuNITdN1nK3qU3ASWDTa0GmVci5iGY7cxjHloaU jgi7aFu19JlR2QJ9NNvunq6LId1WCuymAD84y4mo+Ha+XFBubKY9GEzf9uhKtlVwWVEN d3MxDSN/kB98hAvb0QrN+lpzCq5UQLtdywWvq4568pTapMbaWCMjZkb2Ea9c1zIli/dv lryEWysQS1HnfxOH06iz8PYqFKMw6y8NhdFhKDm0UmBvh9dsuyapFqnrkX6garDpZkru 0MbA== X-Gm-Message-State: AOAM530KXvi6iuJb2zpEYWtudgtuglgLdfIHYetW39Tz0bTmGApfrbol siisxyWc3lkiBxKV1pw6eNtia9Z/T6lnI3rCN8+CcA== X-Google-Smtp-Source: ABdhPJwOQRbnQmQmzaxrSeMY48DkVgG5W+y31u0lUb8/BEz9jaOr8hrUDoAPmHzOrVaamjPz3wtPO3lg/9hV1mJp9ww= X-Received: by 2002:a2e:b0d3:: with SMTP id g19mr557003ljl.279.1610488790674; Tue, 12 Jan 2021 13:59:50 -0800 (PST) MIME-Version: 1.0 References: <20210112095806.I2Z6as5al%akpm@linux-foundation.org> <20210112135010.267508efa85fe98f670ed9e9@linux-foundation.org> In-Reply-To: <20210112135010.267508efa85fe98f670ed9e9@linux-foundation.org> From: Shakeel Butt Date: Tue, 12 Jan 2021 13:59:39 -0800 Message-ID: Subject: Re: mmotm 2021-01-12-01-57 uploaded (NR_SWAPCACHE in mm/) To: Andrew Morton Cc: Randy Dunlap , broonie@kernel.org, linux-fsdevel , LKML , Linux MM , Linux-Next Mailing List , Michal Hocko , mm-commits@vger.kernel.org, Stephen Rothwell Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 12, 2021 at 1:50 PM Andrew Morton w= rote: > > On Tue, 12 Jan 2021 12:38:18 -0800 Randy Dunlap w= rote: > > > On 1/12/21 1:58 AM, akpm@linux-foundation.org wrote: > > > The mm-of-the-moment snapshot 2021-01-12-01-57 has been uploaded to > > > > > > https://www.ozlabs.org/~akpm/mmotm/ > > > > > > mmotm-readme.txt says > > > > > > README for mm-of-the-moment: > > > > > > https://www.ozlabs.org/~akpm/mmotm/ > > > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopeful= ly > > > more than once a week. > > > > > > > on i386 and x86_64: > > > > when CONFIG_SWAP is not set/enabled: > > > > ../mm/migrate.c: In function =E2=80=98migrate_page_move_mapping=E2=80= =99: > > ../mm/migrate.c:504:35: error: =E2=80=98NR_SWAPCACHE=E2=80=99 undeclare= d (first use in this function); did you mean =E2=80=98QC_SPACE=E2=80=99? > > __mod_lruvec_state(old_lruvec, NR_SWAPCACHE, -nr); > > ^~~~~~~~~~~~ > > > > ../mm/memcontrol.c:1529:20: error: =E2=80=98NR_SWAPCACHE=E2=80=99 undec= lared here (not in a function); did you mean =E2=80=98SGP_CACHE=E2=80=99? > > { "swapcached", NR_SWAPCACHE }, > > ^~~~~~~~~~~~ > > Thanks. I did the below. > > But we're still emitting "Node %d SwapCached: 0 kB" in sysfs when > CONFIG_SWAP=3Dn, which is probably wrong. Shakeel, can you please have a > think? > Thanks Andrew for fixing. Independent of this patch, we already print ""SwapCached:" in /proc/meminfo for CONFIG_SWAP=3Dn, so I think doing the same for per-node meminfo should be fine too.