From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA22FC32792 for ; Mon, 22 Aug 2022 15:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236452AbiHVPOZ (ORCPT ); Mon, 22 Aug 2022 11:14:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236444AbiHVPNv (ORCPT ); Mon, 22 Aug 2022 11:13:51 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0032E3FA2A for ; Mon, 22 Aug 2022 08:09:13 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id ds12-20020a17090b08cc00b001fae6343d9fso6008553pjb.0 for ; Mon, 22 Aug 2022 08:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=DL+gliCYJUBpfOq1j0gfe9XybjmiohhXfC5HxYReYKQ=; b=Wy9VrLR+iXIOs02vfJHYtL6p0NbydFm1yZdXSv/BbjuFOkMtSTPP5CovxJ8349YqKj G3MVhdA4OpFY8unEsaSt6zl96K01EATVtDmzrpuZf7ttwrRaJShdhZDkiI3ve+qZNaMO LaMlsEqTM0HnQfbQJ+Ybp1cnhMyLAgbc8INMpkq7KkujbvLbZ3V3a+NkCsxtQtac3dFk vdsSPaw69M8DRRGlUlj8oR/cctPuyyB4P3GQXi7AhcJrZf2VSCnqZnoHSJmlaPfCsIHj Joq2WkpjnyjHGnaNIuUdQt4Q0lg3lljWYfXsxd0kZCxPo/shZ5oEicOIck6uwGYGrqs4 U2ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=DL+gliCYJUBpfOq1j0gfe9XybjmiohhXfC5HxYReYKQ=; b=fbMHnqj4AEDr8zmTU8PcwTc51RURseUR2qahq48/lE/0EUmZlcjs9UZ0k7G+/xrlvx FxdRwsdkXVfSZQECShQi6hGFhc9D+jtHpa137wWeESdy8sjccmLf+ruCl9x44W45zggQ rNjni/SsydSrwS80i4zLUMSBrh/rbekxzZz/zdBIHW3ue2sNbLbDL7VmuJqwiVyWeKtn ZoQdS0mVxQbOTLvFi0S4m4wDHvYwaoKdAHGG4twQaPLCddysBvWQXsi8Ja/fBRGSiKK+ qs2XMgnl+CkIRlUhIunPrT6M+rijc7yGLFjI1MboTnjRJh17DG/Wf5GYod6tmEOKwxa1 Ov5w== X-Gm-Message-State: ACgBeo0CleWoirvkA/nnMEDYWhI684Qe+DvLas1X/o/9ZKd/mDTmKd62 B9bTMmzEZAL3uqIBppJsdqB7rky5FGlkkPF28ZfS5A== X-Google-Smtp-Source: AA6agR7w4i5ZWIz9KjwU7gDt0d0aOILixwzjhdCoo+s9f8xFDqJTQ54c28l9lpA7rWoP1mDiZfxWuiTVUH8q+viQk0c= X-Received: by 2002:a17:90b:3881:b0:1f5:81e:8ceb with SMTP id mu1-20020a17090b388100b001f5081e8cebmr28140119pjb.207.1661180952809; Mon, 22 Aug 2022 08:09:12 -0700 (PDT) MIME-Version: 1.0 References: <20220822001737.4120417-1-shakeelb@google.com> <20220822001737.4120417-4-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Mon, 22 Aug 2022 08:09:01 -0700 Message-ID: Subject: Re: [PATCH 3/3] memcg: increase MEMCG_CHARGE_BATCH to 64 To: Michal Hocko Cc: Johannes Weiner , Roman Gushchin , Muchun Song , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Eric Dumazet , Soheil Hassas Yeganeh , Feng Tang , Oliver Sang , Andrew Morton , lkp@lists.01.org, Cgroups , Linux MM , netdev , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 22, 2022 at 3:47 AM Michal Hocko wrote: > [...] > > > To evaluate the impact of this optimization, on a 72 CPUs machine, we > > ran the following workload in a three level of cgroup hierarchy with top > > level having min and low setup appropriately. More specifically > > memory.min equal to size of netperf binary and memory.low double of > > that. > > a similar feedback to the test case description as with other patches. What more info should I add to the description? Why did I set up min and low or something else? > > > > $ netserver -6 > > # 36 instances of netperf with following params > > $ netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K > > > > Results (average throughput of netperf): > > Without (6.0-rc1) 10482.7 Mbps > > With patch 17064.7 Mbps (62.7% improvement) > > > > With the patch, the throughput improved by 62.7%. > > > > Signed-off-by: Shakeel Butt > > Reported-by: kernel test robot > > Anyway > Acked-by: Michal Hocko Thanks