From: Shakeel Butt <shakeelb@google.com>
To: Waiman Long <longman@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>, Roman Gushchin <guro@fb.com>,
LKML <linux-kernel@vger.kernel.org>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v3 1/2] mm: memcg/slab: Properly set up gfp flags for objcg pointer array
Date: Wed, 5 May 2021 09:09:14 -0700 [thread overview]
Message-ID: <CALvZod6AfOiKC3tmnJzgAJEUKwXwS__n8on59qbmHyHG2XAc4w@mail.gmail.com> (raw)
In-Reply-To: <20210505154613.17214-2-longman@redhat.com>
On Wed, May 5, 2021 at 8:47 AM Waiman Long <longman@redhat.com> wrote:
>
> Since the merging of the new slab memory controller in v5.9, the page
> structure may store a pointer to obj_cgroup pointer array for slab pages.
> Currently, only the __GFP_ACCOUNT bit is masked off. However, the array
> is not readily reclaimable and doesn't need to come from the DMA buffer.
> So those GFP bits should be masked off as well.
>
> Do the flag bit clearing at memcg_alloc_page_obj_cgroups() to make sure
> that it is consistently applied no matter where it is called.
>
> Fixes: 286e04b8ed7a ("mm: memcg/slab: allocate obj_cgroups for non-root slab pages")
> Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
next prev parent reply other threads:[~2021-05-05 16:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 15:46 [PATCH v3 0/2] mm: memcg/slab: Fix objcg pointer array handling problem Waiman Long
2021-05-05 15:46 ` [PATCH v3 1/2] mm: memcg/slab: Properly set up gfp flags for objcg pointer array Waiman Long
2021-05-05 16:09 ` Shakeel Butt [this message]
2021-05-05 16:46 ` Roman Gushchin
2021-05-05 15:46 ` [PATCH v3 2/2] mm: memcg/slab: Create a new set of kmalloc-cg-<n> caches Waiman Long
2021-05-05 16:06 ` Vlastimil Babka
2021-05-05 16:31 ` Waiman Long
2021-05-05 16:17 ` Shakeel Butt
2021-05-05 16:31 ` Waiman Long
2021-05-05 17:30 ` Roman Gushchin
2021-05-05 18:02 ` Vlastimil Babka
2021-05-05 18:18 ` Roman Gushchin
2021-05-05 18:31 ` Waiman Long
2021-05-05 18:38 ` Roman Gushchin
2021-05-05 18:56 ` Waiman Long
2021-05-05 18:32 ` Roman Gushchin
2021-05-05 21:29 ` Vlastimil Babka
2021-05-05 22:19 ` Roman Gushchin
2021-05-05 23:06 ` Waiman Long
2021-05-05 18:11 ` Waiman Long
2021-05-05 18:22 ` Roman Gushchin
2021-05-05 18:54 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod6AfOiKC3tmnJzgAJEUKwXwS__n8on59qbmHyHG2XAc4w@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).