From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A9BC4743D for ; Sat, 5 Jun 2021 04:45:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E68D96141B for ; Sat, 5 Jun 2021 04:45:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbhFEEr3 (ORCPT ); Sat, 5 Jun 2021 00:47:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbhFEEr2 (ORCPT ); Sat, 5 Jun 2021 00:47:28 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 491D6C061767 for ; Fri, 4 Jun 2021 21:45:41 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id w33so17130557lfu.7 for ; Fri, 04 Jun 2021 21:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vow0w7T/H4Ok4yA/drin7CQKErICdzTcTT/vrNcM5Q4=; b=cQpKNyLMQiiglbrRjutBB1ddOTJ0H8uhnwCNG/LXy9JI6NoO9lzdOy1HZVNF2AUCgp +p+rCr2qv9jP3GKnpc3t1Irvf17uRHj9MpYhzTGpzCI39q9t/0ZbxDL/kzuO7O2OE07c QD0ofIbb5nPJaakITyoiShuR/SLGOVJC/BN/LDf4cID895GGCjl4AQqtCFK3HGIL5GOf lCrsT6FzE+7Rd18A1PE02wg0GVG+nqn/DWpMgA+f0ryLKukck/9GhajbiUt1BNUe9Wqe szncH+Or4xHWi9+JvrTkdXFEqbOrpxKFnGctU+/59p3/6PKIoRW6xmt7mxsIdmarHhOK c7ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vow0w7T/H4Ok4yA/drin7CQKErICdzTcTT/vrNcM5Q4=; b=OeojzRqqYmuk88km41PLcoHcUFoEPr6o8+Ie1UtKC2pfjfja2/W918MDoI3UtT6MKr sXOApH/sL5FvrmIhNCFD0wWb4AQWdlIYBrtyQ5CG0l53bbwo8DWSH1BvIjNbCIX+G+dz Ly4jkJIXq5Mjpvb7Z0Ns6h7Kla/Y8R81JzYhdIUciZD5KPn/62b7a3kmJKRnd8OARL5h H+0yJhKuftNr8txa9vzqpKmo2UAsmiDtCEExNER6o1NBKMyNU5ogSVX6bWvy5IJi+hg+ Il0UEH8yq74czCVDuDujU3QVF+cWjBB35RQ0roLnFXXX1Uq3Q+mH5yPgeCfTtg68gYQg aVGQ== X-Gm-Message-State: AOAM530yjQ+/Ws0YzuE8nKlfEwmIYaXwP0FgfyAmbbl9CZgq1uRlKLN7 OIgdl+L0q0UfjLzKjRqeNN8BFgm/r6pGw78/tW+oPQ== X-Google-Smtp-Source: ABdhPJwQoGzX28kw7JKRXYgL5n6FP6kpxLErtYAUQ4PvLx/uwUiZYxfr8DzUpLIwdqw3wtn0D5rmMlrCsiM0eKjbe3w= X-Received: by 2002:a05:6512:952:: with SMTP id u18mr4785726lft.83.1622868339254; Fri, 04 Jun 2021 21:45:39 -0700 (PDT) MIME-Version: 1.0 References: <20210604015640.2586269-1-shakeelb@google.com> <20210604061816.3110-1-hdanton@sina.com> <20210605015421.5096-1-hdanton@sina.com> In-Reply-To: From: Shakeel Butt Date: Fri, 4 Jun 2021 21:45:28 -0700 Message-ID: Subject: Re: [PATCH 2/2] memcg: periodically flush the memcg stats To: Tejun Heo Cc: Hillf Danton , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Huang Ying , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 4, 2021 at 7:33 PM Tejun Heo wrote: > > On Sat, Jun 05, 2021 at 09:54:21AM +0800, Hillf Danton wrote: > > The cond_resched() in cgroup_rstat_flush_locked() matches its appearence in > > your post [1]. So does unbound IMHO. > > Ah yeah, this either needs CPU_INTENSIVE or UNBOUND, prolly the latter is > better. > I will change the next version to the system_unbound_wq.