From: Shakeel Butt <shakeelb@google.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: kernel test robot <oliver.sang@intel.com>,
Vasily Averin <vvs@virtuozzo.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrei Vagin <avagin@gmail.com>, Borislav Petkov <bp@alien8.de>,
Borislav Petkov <bp@suse.de>,
Christian Brauner <christian.brauner@ubuntu.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@kernel.org>,
Jiri Slaby <jirislaby@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Michal Hocko <mhocko@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
Roman Gushchin <guro@fb.com>, Serge Hallyn <serge@hallyn.com>,
Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Yutian Yang <nglaive@gmail.com>,
Zefan Li <lizefan.x@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
lkp@lists.01.org, kernel test robot <lkp@intel.com>,
Huang Ying <ying.huang@intel.com>,
Feng Tang <feng.tang@intel.com>,
Xing Zhengjun <zhengjun.xing@linux.intel.com>
Subject: Re: [memcg] 0f12156dff: will-it-scale.per_process_ops -33.6% regression
Date: Tue, 7 Sep 2021 08:57:42 -0700 [thread overview]
Message-ID: <CALvZod6S+NmG8+-ftS-w3t3zJg_kbr3-F9h-n4jwSnqh0jTUGQ@mail.gmail.com> (raw)
In-Reply-To: <dbc9955d-6c28-1dd5-b842-ef39a762aa3b@kernel.dk>
On Tue, Sep 7, 2021 at 8:46 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 9/7/21 9:07 AM, kernel test robot wrote:
> >
> >
> > Greeting,
> >
> > FYI, we noticed a -33.6% regression of will-it-scale.per_process_ops due to commit:
> >
> >
> > commit: 0f12156dff2862ac54235fc72703f18770769042 ("memcg: enable accounting for file lock caches")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> Are we at all worried about these? There's been a number of them
> reported, basically for all the accounting enablements that have been
> done in this merge window.
>
> When io_uring was switched to use accounted memory, we did a bunch of
> work to ameliorate the inevitable slowdowns that happen if you do
> repeated allocs and/or frees and have memcg accounting enabled.
>
I think these are important and we should aim to continuously improve
performance with memcg accounting. I would like to know more about the
io_uring work done to improve memcg accounting. Maybe we can
generalize it to others as well.
next prev parent reply other threads:[~2021-09-07 15:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 15:07 [memcg] 0f12156dff: will-it-scale.per_process_ops -33.6% regression kernel test robot
2021-09-07 15:46 ` Jens Axboe
2021-09-07 15:57 ` Shakeel Butt [this message]
2021-09-07 16:14 ` Jens Axboe
2021-09-07 16:39 ` Linus Torvalds
2021-09-07 16:43 ` Jens Axboe
2021-09-07 17:11 ` Roman Gushchin
2021-09-07 17:14 ` Tejun Heo
2021-09-07 17:18 ` Jens Axboe
2021-09-07 17:20 ` Tejun Heo
2021-09-07 17:31 ` Roman Gushchin
2021-09-07 17:48 ` Shakeel Butt
2021-09-07 19:42 ` Roman Gushchin
2021-09-08 8:13 ` Vasily Averin
2022-04-29 13:10 ` Michal Koutný
2021-09-07 16:49 ` Shakeel Butt
2021-09-07 17:52 ` Linus Torvalds
2021-09-07 18:19 ` Shakeel Butt
2021-09-07 18:33 ` Linus Torvalds
[not found] ` <64b88941-9ec0-8552-d05d-6503497f6f9d@MichaelLarabel.com>
2021-09-16 20:44 ` memcg: infrastructure to flush memcg stats Linus Torvalds
2021-09-16 21:04 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod6S+NmG8+-ftS-w3t3zJg_kbr3-F9h-n4jwSnqh0jTUGQ@mail.gmail.com \
--to=shakeelb@google.com \
--cc=0x7f454c46@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@gmail.com \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=jlayton@kernel.org \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=nglaive@gmail.com \
--cc=oleg@redhat.com \
--cc=oliver.sang@intel.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov.dev@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vvs@virtuozzo.com \
--cc=ying.huang@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).