From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7929AC4338F for ; Wed, 11 Aug 2021 00:18:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B43160F25 for ; Wed, 11 Aug 2021 00:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235890AbhHKATI (ORCPT ); Tue, 10 Aug 2021 20:19:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235742AbhHKASb (ORCPT ); Tue, 10 Aug 2021 20:18:31 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD11C06179C for ; Tue, 10 Aug 2021 17:18:07 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id z20so1695195lfd.2 for ; Tue, 10 Aug 2021 17:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KkFE6Z56Mr1EKMwPtDhJ4HsMjjvC1ODc/Bi7DtZL3y4=; b=KjMIw7uHjs9/YFLEilGT6TLdaKipi6iIbPCY43mmgLVcnbQgJph4S5OZ7tmYL0z102 ASyygdAuIVEWbPB+5xylWE8nG874v/uIuTBOPiH+ZvgyoAzHAdmKTrK2t/lqz3aW5zzI k4cK1w/KhthEZqa9FydIVOnNXA1pZBZCfINF19J0oFDF1kQrnvw1TLg3uh1b9xMBXh9m Ok/7PeN9IsfUD8s+QtEEktIB3hafsmo1ZVpoEGxsbh/z6YWAK06ACu+mWkLhcXkgs4Tz y8lGeKym94+EFHQv3ZucB+1rEFd7TQk0B6oWb6EVhOexgOdOAF+dt9jKIuFuKlvSwFWP IjTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KkFE6Z56Mr1EKMwPtDhJ4HsMjjvC1ODc/Bi7DtZL3y4=; b=Jz8rYw9alWRFY0B8GxmuGVrsL7atQyTKi/Tv4cuFgBxgsm6m/yEcQ02ZUXgB2yqHs2 7jlwRXnKbnFU0QPUw/Q8qZN4k8Gj59d/DMAl0aB1Zxvf4wwAZMWpSAIIlFlR2b9K3PhK Kmd1FWgVSpIs0YV9j/Aok+q2cXtKCVY2CgZnwmnJd5gHFJC5eXrzA4GFafGDpvgy/zic GZfG9uP00hq9OnIV6iU06qWCRNmrmGhiLFps0YhaEhhBCeOS7rOaTNAdb334kY9Bd+BQ dYUSmc6qlRc/cHK6GColz+RP+VmkeuvkLLplARQG8p350wx/Wcbt0YTd1EQABkUCs0Zk rc+A== X-Gm-Message-State: AOAM530XcWOX8iF9qMyxI19yzJKSql300IGjpa46cMU2Cz15Z49SAF9q sitnitkatpNeuTgEJlgQRKvNTw5sIbCjOMHI9upzsQ== X-Google-Smtp-Source: ABdhPJxhBg2LH2EJ+Bu3ELKjg0fU85Or2rS0VRsoUVvFWCifWBcbkWW428Z555bCdngbTg8uYMmFkuES5F+iS75w8XE= X-Received: by 2002:ac2:57cd:: with SMTP id k13mr24099569lfo.117.1628641086038; Tue, 10 Aug 2021 17:18:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Shakeel Butt Date: Tue, 10 Aug 2021 17:17:53 -0700 Message-ID: Subject: Re: [PATCH] mm/slub, kasan: fix checking page_alloc allocations on free To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , kasan-dev@googlegroups.com, Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 4:47 PM wrote: > > From: Andrey Konovalov > > A fix for stat counters f227f0faf63b ("slub: fix unreclaimable slab stat > for bulk free") used page_address(page) as kfree_hook() argument instead > of object. While the change is technically correct, it breaks KASAN's > ability to detect improper (unaligned) pointers passed to kfree() and > causes the kmalloc_pagealloc_invalid_free test to fail. > > This patch changes free_nonslab_page() to pass object to kfree_hook() > instead of page_address(page) as it was before the fix. > > Fixed: f227f0faf63b ("slub: fix unreclaimable slab stat for bulk free") > Signed-off-by: Andrey Konovalov The fix is already in the mm tree: https://lkml.kernel.org/r/20210802180819.1110165-1-shakeelb@google.com