From: Shakeel Butt <shakeelb@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Kernel Team <kernel-team@fb.com>,
LKML <linux-kernel@vger.kernel.org>,
Josef Bacik <josef@toxicpanda.com>,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Linux MM <linux-mm@kvack.org>, Mel Gorman <mgorman@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] net: fix sk_page_frag() recursion from memory reclaim
Date: Thu, 31 Oct 2019 11:51:57 -0700 [thread overview]
Message-ID: <CALvZod7Lm5d-84wWubTUOFWo4XU2cgqBpFw84QzFdiokX86COQ@mail.gmail.com> (raw)
In-Reply-To: <20191031184346.GM3622521@devbig004.ftw2.facebook.com>
On Thu, Oct 31, 2019 at 11:43 AM Tejun Heo <tj@kernel.org> wrote:
>
> Hello,
>
> On Thu, Oct 31, 2019 at 11:30:57AM -0700, Shakeel Butt wrote:
> > Basically what I wanted to say that MM treats PF_MEMALLOC as the
> > reclaim context while __GFP_MEMALLOC just tells to give access to the
> > reserves. As gfpflags_allow_blocking() can be used beyond net
> > subsystem, my only concern is its potential usage under PF_MEMALLOC
> > context but without __GFP_MEMALLOC.
>
> Yeah, PF_MEMALLOC is likely the better condition to check here as we
> primarily want to know whether %current might be recursing and that
> should be indicated reliably with PF_MEMALLOC. Wanna prep a patch for
> it?
Sure, I will keep your commit message and authorship (if you are ok with it).
>
> Thanks.
>
> --
> tejun
next prev parent reply other threads:[~2019-10-31 18:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 17:01 [PATCH] net: fix sk_page_frag() recursion from memory reclaim Tejun Heo
2019-10-19 18:15 ` Eric Dumazet
2019-10-19 21:18 ` Tejun Heo
2019-10-19 21:25 ` Eric Dumazet
2019-10-22 17:19 ` Jakub Kicinski
2019-10-24 20:50 ` [PATCH v2] " Tejun Heo
2019-10-28 23:18 ` David Miller
2019-10-31 17:35 ` Shakeel Butt
2019-10-31 17:47 ` Eric Dumazet
2019-10-31 18:30 ` Shakeel Butt
2019-10-31 18:43 ` Tejun Heo
2019-10-31 18:51 ` Shakeel Butt [this message]
2019-10-31 19:00 ` Tejun Heo
2019-10-31 19:14 ` Shakeel Butt
2019-10-31 19:16 ` Tejun Heo
2019-10-31 23:20 ` Andrew Morton
2019-11-01 17:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod7Lm5d-84wWubTUOFWo4XU2cgqBpFw84QzFdiokX86COQ@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=jakub.kicinski@netronome.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).