From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF5DC07E9B for ; Fri, 9 Jul 2021 16:00:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E2FB613CC for ; Fri, 9 Jul 2021 16:00:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232537AbhGIQDi (ORCPT ); Fri, 9 Jul 2021 12:03:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232345AbhGIQDg (ORCPT ); Fri, 9 Jul 2021 12:03:36 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB0DC0613E5 for ; Fri, 9 Jul 2021 09:00:53 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id c28so23667935lfp.11 for ; Fri, 09 Jul 2021 09:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/xZI0OajFf5/ziUaY+H5m9Nzo8ghS9n7erS+9RJcXYI=; b=W8p7yxoX3G5IefHMsRi4RO40HwPkUuZKO3Wv0ZsSnEGlWk9UWvnKmQGYINVPYcChA9 WqVnGAT7Ht7kptj0cHK+RO8ue80geR+dn9mK06BE+MSmBWZxzpFqj2liQKKsHQHwEm8/ 9adlW2sI8CwSPhxv6HJlqtEhnnly5kd4B07uwGmd8xdOgTfH1L2I0TPxkaJjN8DDlkDD 1YtUnGHXQCYRub16v4ymPOdl3+c8L4KyEZjjF4acYce5MxvCBZ1TeeoUX+rWBAMUwjrR qfVOlkfEB974p6LhdqPzqpMyry1nWccBFX0SbgLebwQ9nEFcv5nZaY0H5dTUUHBoyq0a k+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/xZI0OajFf5/ziUaY+H5m9Nzo8ghS9n7erS+9RJcXYI=; b=CaVhSNlaN/SkK3d6QUJu5mwAto1vkIh7z3NY6lAuBCes4ce1E5tpyNOYG4Ya+4/T/w XW1FjwwW/FogJOFebz1+uM5j7mPuzQx1OlksOMigxC5ZjqVpeyQuKbhKNJ+is4EpqnNl T+NeWaGIeDg6/+rM/dtk9sBUfRQ2ggD2sXq9GTGcIQcFWncGF6tYvt6sMhBp91tUCwBu XTmTJ8iPs18Xb+Mevi9h0xcffDyyEpAjN+3efXbd8Qn22MF/uVZLINiUZYL6opcUSzjg j47IURZa8jHHpNL3BJqCr0GnqvGyq7ZZjB1ejpK02lth0xu3IhNrqvsY839H+4WciG7C QldQ== X-Gm-Message-State: AOAM530SBhMvV6LZTmiwL2zT5oAGmcaHYYLdcuqDmnt7cSFJCnV003Fj hJuktbym4RpDvBjEOQo/tUUnvjZtQV9BvFPknIwmpw== X-Google-Smtp-Source: ABdhPJzHHw49xv/agytETvqSChc4oU4k6Uy1gyLX68+KTNT1rad2pHALpVI3rzlltSe/tgTntSYsjF1LYD8VqnNkNdo= X-Received: by 2002:a19:ad4d:: with SMTP id s13mr13304956lfd.432.1625846451059; Fri, 09 Jul 2021 09:00:51 -0700 (PDT) MIME-Version: 1.0 References: <20210709000509.2618345-1-surenb@google.com> <20210709000509.2618345-2-surenb@google.com> In-Reply-To: <20210709000509.2618345-2-surenb@google.com> From: Shakeel Butt Date: Fri, 9 Jul 2021 09:00:39 -0700 Message-ID: Subject: Re: [PATCH 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Muchun Song , Yang Shi , alexs@kernel.org, Alexander Duyck , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , Matthew Wilcox , Alistair Popple , Minchan Kim , Miaohe Lin , LKML , Cgroups , Linux MM , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 8, 2021 at 5:05 PM Suren Baghdasaryan wrote: > [...] > --- a/mm/vmpressure.c > +++ b/mm/vmpressure.c > @@ -240,7 +240,12 @@ static void vmpressure_work_fn(struct work_struct *work) > void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree, > unsigned long scanned, unsigned long reclaimed) > { > - struct vmpressure *vmpr = memcg_to_vmpressure(memcg); > + struct vmpressure *vmpr; > + > + if (mem_cgroup_disabled()) > + return; > + > + vmpr = memcg_to_vmpressure(memcg); I was wondering why this was not crashing but realized that we allocate root_mem_cgroup even in cgroup_disable=memory case. Reviewed-by: Shakeel Butt