From: Firoz Khan <firoz.khan@linaro.org>
To: Helge Deller <deller@gmx.de>
Cc: linux-parisc@vger.kernel.org,
"James E . J . Bottomley" <jejb@parisc-linux.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation
Date: Thu, 11 Oct 2018 11:44:13 +0530 [thread overview]
Message-ID: <CALxhOnhcP==cGqMQvtrZ9GiNWGB69hz4G0n0kocBtd9NpDthCg@mail.gmail.com> (raw)
In-Reply-To: <CALxhOnjxkq1-N59i81+ra58tZhx7Gik6iPyUsNFJY9wEJA+D1w@mail.gmail.com>
Typo fixed!
On Thu, 11 Oct 2018 at 11:40, Firoz Khan <firoz.khan@linaro.org> wrote:
>
> Hi Helge,
>
> On Wed, 10 Oct 2018 at 01:48, Helge Deller <deller@gmx.de> wrote:
> >
> > * Firoz Khan <firoz.khan@linaro.org>:
> > > System call table generation script must be run to generate
> > > unistd_32/64.h and syscall_table_32/64/c32.h files. This patch
> > > will have changes which will invokes the script.
> > >
> > > This patch will generate unistd_32/64.h and syscall_table_
> > > 32/64/c32.h files by the syscall table generation script
> > > invoked by arch/parisc/Makefile and the generated files against
> > > the removed files will be identical.
> > >
> > > The generated uapi header file will be included in uapi/asm/
> > > unistd_32/64.h and generated system call table support file will
> > > be included by arch/sparc/kernel/syscall_table_32/64.S file.
> > >
> > > Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
> > > ---
> > > arch/parisc/Makefile | 4 +
> > > arch/parisc/include/asm/Kbuild | 3 +
> > > arch/parisc/include/uapi/asm/Kbuild | 2 +
> > > arch/parisc/include/uapi/asm/unistd.h | 373 +--------------------------
> > > arch/parisc/kernel/syscall.S | 12 +-
> > > arch/parisc/kernel/syscall_table.S | 459 ----------------------------------
> >
> >
> > Can we please get rid of those two new files:
>
> Yes, we don't need those files some of the architecture and other
> architecture does have same/similar files. That's why I added below
Yes, we don't need those files some of the architecture does have ...
> files, so every architecture implementation looks same.
>
> I feel it is better to remove these files.
> Arnd, Do u have any comment on this?
>
> Thanks
> Firoz
>
> >
> > > arch/parisc/kernel/syscall_table_32.S | 13 +
> > > arch/parisc/kernel/syscall_table_64.S | 20 ++
> >
> > Both are not needed (at least on parisc) if you apply the following
> > patch on top of your patch series.
> > This patch finally fixes the 64-bit kernel on parisc (tested on real
> > hardware).
> >
> > Helge
> >
> > diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S
> > index 2523b83b88d8..45cddeeb968f 100644
> > --- a/arch/parisc/kernel/syscall.S
> > +++ b/arch/parisc/kernel/syscall.S
> > @@ -923,10 +923,20 @@ ENTRY(lws_table)
> > END(lws_table)
> > /* End of lws table */
> >
> > -#include "syscall_table_32.S"
> > +#define __SYSCALL(nr, entry, nargs) ASM_ULONG_INSN entry
> > +
> > +ENTRY(sys_call_table)
> > +#if defined(CONFIG_64BIT)
> > +#include <asm/syscall_table_c32.h> /* compat syscalls */
> > +#else
> > +#include <asm/syscall_table_32.h> /* 32-bit native syscalls */
> > +#endif
> > +END(sys_call_table)
> > +
> > #ifdef CONFIG_64BIT
> > -#define SYSCALL_TABLE_64BIT
> > -#include "syscall_table_64.S"
> > +ENTRY(sys_call_table64)
> > +#include <asm/syscall_table_64.h> /* 64-bit native syscalls */
> > +END(sys_call_table64)
> > #endif
> >
> > /*
next prev parent reply other threads:[~2018-10-11 6:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 5:16 [PATCH v3 0/6] System call table generation support Firoz Khan
2018-10-08 5:16 ` [PATCH v3 1/6] parisc: move __IGNORE* entries to non uapi header Firoz Khan
2018-10-08 5:16 ` [PATCH v3 2/6] parisc: add __NR_Linux_syscalls along with __NR_syscalls Firoz Khan
2018-10-08 5:16 ` [PATCH v3 3/6] parisc: add system call table generation support Firoz Khan
2018-10-08 7:33 ` Firoz Khan
2018-10-08 13:03 ` Eugene Syromiatnikov
2018-10-08 13:56 ` Arnd Bergmann
2018-10-09 5:35 ` Firoz Khan
2018-10-09 5:40 ` Firoz Khan
2018-10-09 7:47 ` Arnd Bergmann
2018-10-09 9:36 ` Firoz Khan
2018-10-09 11:28 ` Arnd Bergmann
2018-10-09 14:10 ` Firoz Khan
2018-10-08 5:16 ` [PATCH v3 4/6] parisc: uapi header and system call table file generation Firoz Khan
2018-10-08 19:43 ` Helge Deller
2018-10-09 4:56 ` Firoz Khan
2018-10-09 20:13 ` Helge Deller
2018-10-11 6:10 ` Firoz Khan
2018-10-11 6:14 ` Firoz Khan [this message]
2018-10-11 6:48 ` Firoz Khan
2018-10-11 7:03 ` Arnd Bergmann
2018-10-11 10:27 ` Helge Deller
2018-10-11 15:01 ` Firoz Khan
2018-10-11 7:07 ` Arnd Bergmann
2018-10-11 8:30 ` Firoz Khan
2018-10-08 5:16 ` [PATCH v3 5/6] parisc: wire up rseq system call Firoz Khan
2018-10-08 5:36 ` Helge Deller
2018-10-08 5:52 ` Firoz Khan
2018-10-08 6:06 ` Helge Deller
2018-10-08 6:48 ` Firoz Khan
2018-10-08 8:23 ` Geert Uytterhoeven
2018-10-08 8:55 ` Firoz Khan
2018-10-08 8:58 ` Geert Uytterhoeven
2018-10-08 9:11 ` Arnd Bergmann
2018-10-08 5:16 ` [PATCH v3 6/6] parisc: syscalls: Ignore nfsservctl for other architectures Firoz Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALxhOnhcP==cGqMQvtrZ9GiNWGB69hz4G0n0kocBtd9NpDthCg@mail.gmail.com' \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@parisc-linux.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).