From: Firoz Khan <firoz.khan@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "open list:RALINK MIPS ARCHITECTURE" <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v3 5/6] mips: add system call table generation support
Date: Fri, 30 Nov 2018 10:35:02 +0530 [thread overview]
Message-ID: <CALxhOnivqOdpZ8WRK3Lx9ScApa34MS6riTwFz15aS7GTGf6QQA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1KcUQEbavu1eZaoKXTmbdbxiKgVqt6XF-PeeSSbpVEVg@mail.gmail.com>
Hi Arnd,
Thanks for your email.
On Thu, 29 Nov 2018 at 19:46, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Nov 29, 2018 at 9:44 AM Firoz Khan <firoz.khan@linaro.org> wrote:
> >
> > The system call tables are in different format in all
> > architecture and it will be difficult to manually add,
> > modify or delete the syscall table entries in the res-
> > pective files. To make it easy by keeping a script and
> > which will generate the uapi header and syscall table
> > file. This change will also help to unify the implemen-
> > tation across all architectures.
> >
> > The system call table generation script is added in
> > kernel/syscalls directory which contain the scripts to
> > generate both uapi header file and system call table
> > files. The syscall.tbl will be input for the scripts.
> >
> > syscall.tbl contains the list of available system calls
> > along with system call number and corresponding entry
> > point. Add a new system call in this architecture will
> > be possible by adding new entry in the syscall.tbl file.
> >
> > Adding a new table entry consisting of:
> > - System call number.
> > - ABI.
> > - System call name.
> > - Entry point name.
> > - Compat entry name, if required.
> >
> > syscallhdr.sh and syscalltbl.sh will generate uapi
> > header unistd_64/n32/o32.h and syscall_table_32_o32/-
> > 64_64/64-n32/64-o32.h files respectively. Both .sh files
> > will parse the content syscall.tbl to generate the header
> > and table files. unistd_64/n32/o32.h will be included by
> > uapi/asm/unistd.h and syscall_table_32_o32/64_64/64-n32-
> > /64-o32.h is included by kernel/syscall_table32_o32/64-
> > _64/64-n32/64-o32.S - the real system call table.
> >
> > ARM, s390 and x86 architecuture does have similar support.
> > I leverage their implementation to come up with a generic
> > solution.
> >
> > Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
>
> Ah, I see you added the syscallnr.sh script from ARM. I guess
> that is one way to handle it, and the implementation seems
> fine. It would be good to mention it in the changelog text above
> though.
I came across the file name - syscallnr.sh in ARM long back and I
used it here.
Everyone - Arnd pointed out __NR_syscalls assignment issue in my
v2 patches. For that, I came across those macros to be part of the
generated file. So I created another script - syscallnr.sh just write
__NR_N32/N64/O32_Linux, __NR_N32/N64/O32_Linux_syscalls
to the generated file. I had 1:1 chat with Paul also and he share few
concerns to convert above macros to be variable.
The advantage of adding another script is the other two scripts -
syscallhdr.sh and syscalltbl.sh are identical across all other 10
architecture. If we are trying to come up with a common script,
hopefully the effort will be minimal.
Yes, I can update the change log.
Paul, Could you help me to review this patch series and perform
the boot test on actual platform.
FYI, I could send v4 (clean one) next week mid as I'm on a vacation
couple of days.
Thanks
Firoz
>
> Arnd
next prev parent reply other threads:[~2018-11-30 5:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 8:43 [PATCH v3 0/6] mips: system call table generation support Firoz Khan
2018-11-29 8:43 ` [PATCH v3 1/6] mips: add __NR_syscalls along with __NR_Linux_syscalls Firoz Khan
2018-11-29 14:10 ` Arnd Bergmann
2018-11-30 4:45 ` Firoz Khan
2018-11-29 8:43 ` [PATCH v3 2/6] mips: remove unused macros Firoz Khan
2018-11-29 8:43 ` [PATCH v3 3/6] mips: add +1 to __NR_syscalls in uapi header Firoz Khan
2018-11-29 8:43 ` [PATCH v3 4/6] mips: remove syscall table entries Firoz Khan
2018-11-29 8:43 ` [PATCH v3 5/6] mips: add system call table generation support Firoz Khan
2018-11-29 14:15 ` Arnd Bergmann
2018-11-30 5:05 ` Firoz Khan [this message]
2018-11-29 8:43 ` [PATCH v3 6/6] mips: generate uapi header and system call table files Firoz Khan
2018-11-29 14:22 ` Arnd Bergmann
2018-11-30 5:13 ` Firoz Khan
2018-12-04 4:03 ` [PATCH v3 0/6] mips: system call table generation support Firoz Khan
2018-12-05 6:34 ` Paul Burton
2018-12-05 7:12 ` Firoz Khan
2018-12-06 12:15 ` Maciej W. Rozycki
2018-12-06 16:19 ` Joseph Myers
2018-12-06 17:02 ` Maciej W. Rozycki
2018-12-06 17:20 ` Joseph Myers
2018-12-06 17:43 ` Maciej W. Rozycki
2018-12-06 18:10 ` Florian Weimer
2018-12-07 14:33 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALxhOnivqOdpZ8WRK3Lx9ScApa34MS6riTwFz15aS7GTGf6QQA@mail.gmail.com \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=paul.burton@mips.com \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).