From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E665DC32788 for ; Thu, 11 Oct 2018 06:48:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E5B02077C for ; Thu, 11 Oct 2018 06:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="BztreXOe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E5B02077C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727464AbeJKOOZ (ORCPT ); Thu, 11 Oct 2018 10:14:25 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:37752 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726135AbeJKOOZ (ORCPT ); Thu, 11 Oct 2018 10:14:25 -0400 Received: by mail-yw1-f66.google.com with SMTP id y14-v6so3184222ywa.4 for ; Wed, 10 Oct 2018 23:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7CTJJugyo1ro7MN6SU8cXgLshPlXyKVBZHyuWcw4JN0=; b=BztreXOesfYWkaaHboa8dXF6y3B7ANAKZx7lEPPCIk5v+0794M2RsGNiJDXKJZa3Vk meFPZ7VMT/c2OSlLjV0Hihcpb8ZQRRvJ3dzMm6x3+8IvMDLqzsjLczohICDkOCT1hv1b f8itwDNhLIw3sjT5ao+wyDyu+kPX2g+kzrD58= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7CTJJugyo1ro7MN6SU8cXgLshPlXyKVBZHyuWcw4JN0=; b=CMpnX8rtyOmX9FVX7GDlCvb0bYDz9jSrh2HQnZPrDmQ0WRz8RkAvdzTaqg7XSAINmm y3QKWG2q7nxXiUELgZzlZZu87eXH0wMMqO4Ngkt8P53SUf511Zd8Lc9ivN5JBEJZd0mt JoK+V7khKuwNulOrb4PjiLYN9gWJWSDzgnYOjycOz7uqffq/UGbFbwo9Q8mGHD5ynv4s 1JVMY2kEeO68aLNe+ndQsEUKtPCpnHbADv4JzB5olbUJAnZhzjOPWzQG46XMDaBahFIw O1QGDrlDd3mlSt5R4StAfk2n2ZmQ1fH7++K0o+Oyqm2FPtql6vvoPy84SNlaT+3Q2JkV R31w== X-Gm-Message-State: ABuFfog4i/jiz1xB1WEMqb53wk7gbFmh5r7Bw3QmQAZ/MZUuB/SIeVy0 gg7SuasqLB895BUenwkhsyspGKpAfml5lKc+emgJrQ== X-Google-Smtp-Source: ACcGV60aPhsR1j2bWE4kWaT99cJSAACGbTHt4k0pWGmweZ0sijfRdrxMoSYnpFzDNArNZXJCX6ZcX/1vZS1LRvOdU+I= X-Received: by 2002:a81:1b85:: with SMTP id b127-v6mr142321ywb.381.1539240513180; Wed, 10 Oct 2018 23:48:33 -0700 (PDT) MIME-Version: 1.0 References: <1538975801-13735-1-git-send-email-firoz.khan@linaro.org> <1538975801-13735-5-git-send-email-firoz.khan@linaro.org> <20181009201321.GA28911@ls3530.fritz.box> In-Reply-To: From: Firoz Khan Date: Thu, 11 Oct 2018 12:18:21 +0530 Message-ID: Subject: Re: [PATCH v3 4/6] parisc: uapi header and system call table file generation To: Helge Deller Cc: linux-parisc@vger.kernel.org, "James E . J . Bottomley" , Thomas Gleixner , Greg Kroah-Hartman , Philippe Ombredanne , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , Linux-Arch , Arnd Bergmann , Deepa Dinamani , Marcin Juszkiewicz Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Helge, On Thu, 11 Oct 2018 at 11:40, Firoz Khan wrote: > > Hi Helge, > > On Wed, 10 Oct 2018 at 01:48, Helge Deller wrote: > > > > * Firoz Khan : > > > System call table generation script must be run to generate > > > unistd_32/64.h and syscall_table_32/64/c32.h files. This patch > > > will have changes which will invokes the script. > > > > > > This patch will generate unistd_32/64.h and syscall_table_ > > > 32/64/c32.h files by the syscall table generation script > > > invoked by arch/parisc/Makefile and the generated files against > > > the removed files will be identical. > > > > > > The generated uapi header file will be included in uapi/asm/ > > > unistd_32/64.h and generated system call table support file will > > > be included by arch/sparc/kernel/syscall_table_32/64.S file. > > > > > > Signed-off-by: Firoz Khan > > > --- > > > arch/parisc/Makefile | 4 + > > > arch/parisc/include/asm/Kbuild | 3 + > > > arch/parisc/include/uapi/asm/Kbuild | 2 + > > > arch/parisc/include/uapi/asm/unistd.h | 373 +-------------------------- > > > arch/parisc/kernel/syscall.S | 12 +- > > > arch/parisc/kernel/syscall_table.S | 459 ---------------------------------- > > > > > > Can we please get rid of those two new files: > > Yes, we don't need those files some of the architecture and other > architecture does have same/similar files. That's why I added below > files, so every architecture implementation looks same. > > I feel it is better to remove these files. > Arnd, Do u have any comment on this? > > Thanks > Firoz > > > > > > arch/parisc/kernel/syscall_table_32.S | 13 + > > > arch/parisc/kernel/syscall_table_64.S | 20 ++ > > > > Both are not needed (at least on parisc) if you apply the following > > patch on top of your patch series. > > This patch finally fixes the 64-bit kernel on parisc (tested on real > > hardware). > > > > Helge > > > > diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S > > index 2523b83b88d8..45cddeeb968f 100644 > > --- a/arch/parisc/kernel/syscall.S > > +++ b/arch/parisc/kernel/syscall.S > > @@ -923,10 +923,20 @@ ENTRY(lws_table) > > END(lws_table) > > /* End of lws table */ > > > > -#include "syscall_table_32.S" > > +#define __SYSCALL(nr, entry, nargs) ASM_ULONG_INSN entry > > + > > +ENTRY(sys_call_table) > > +#if defined(CONFIG_64BIT) > > +#include /* compat syscalls */ > > +#else > > +#include /* 32-bit native syscalls */ > > +#endif > > +END(sys_call_table) > > + > > #ifdef CONFIG_64BIT > > -#define SYSCALL_TABLE_64BIT > > -#include "syscall_table_64.S" > > +ENTRY(sys_call_table64) > > +#include /* 64-bit native syscalls */ > > +END(sys_call_table64) > > #endif > > > > /* I could see a patch (commit 47514da3ac20150cdf764466fbc2010c0fca0163) which will perform a compile-check when adding a new syscall. My patches will remove this feature. Is that fine? Firoz