From: Ban Feng <baneric926@gmail.com>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
corbet@lwn.net, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, kcfeng0@nuvoton.com,
kwliu@nuvoton.com, openbmc@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
DELPHINE_CHIU@wiwynn.com, naresh.solanki@9elements.com,
billy_tsai@aspeedtech.com
Subject: Re: [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y
Date: Thu, 7 Mar 2024 15:36:16 +0800 [thread overview]
Message-ID: <CALz278ad+c6=BCrmHW9GfC3WkkOyhyvoR0xYxmi=_awUmjhdqw@mail.gmail.com> (raw)
In-Reply-To: <cffada5e-0f7a-415f-9c4b-7c46fac5cd3a@hatter.bewilderbeest.net>
Hi Zev,
On Tue, Mar 5, 2024 at 8:28 AM Zev Weiss <zev@bewilderbeest.net> wrote:
>
> On Sat, Mar 02, 2024 at 12:19:07AM PST, Zev Weiss wrote:
> >On Mon, Feb 26, 2024 at 04:56:06PM PST, baneric926@gmail.com wrote:
>
> <snip>
>
> >
> >>+
> >>+ fanin_cnt = of_property_count_u8_elems(child, "tach-ch");
> >>+ if (fanin_cnt < 1)
> >
> >fanin_cnt < 1 || fanin_cnt >= NCT7363_PWM_COUNT
> >
>
> Er, off by one -- just '>' rather than '>=' there I realize now.
ok, fix in v5
Thanks,
Ban
>
>
> Zev
>
next prev parent reply other threads:[~2024-03-07 7:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 0:56 [PATCH v4 0/3] hwmon: Driver for Nuvoton NCT7363Y baneric926
2024-02-27 0:56 ` [PATCH v4 1/3] dt-bindings: hwmon: fan: Add fan binding to schema baneric926
2024-03-05 0:22 ` Zev Weiss
2024-03-05 0:41 ` Guenter Roeck
2024-03-05 0:49 ` Guenter Roeck
2024-03-07 7:41 ` Ban Feng
2024-03-07 18:53 ` Guenter Roeck
2024-03-18 0:58 ` Ban Feng
2024-02-27 0:56 ` [PATCH v4 2/3] dt-bindings: hwmon: Add NCT7363Y documentation baneric926
2024-02-28 7:30 ` Paul Menzel
2024-03-06 7:56 ` Ban Feng
2024-02-27 0:56 ` [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y baneric926
2024-02-28 7:57 ` Paul Menzel
2024-02-28 9:03 ` Guenter Roeck
2024-02-28 11:03 ` Paul Menzel
2024-02-28 16:03 ` Guenter Roeck
2024-02-28 16:25 ` Commit messages (was: [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y) Paul Menzel
2024-03-07 0:58 ` Ban Feng
2024-03-07 0:55 ` [PATCH v4 3/3] hwmon: Driver for Nuvoton NCT7363Y Ban Feng
2024-03-02 8:18 ` Zev Weiss
2024-03-05 0:28 ` Zev Weiss
2024-03-07 7:36 ` Ban Feng [this message]
2024-03-07 7:35 ` Ban Feng
2024-03-12 23:18 ` Zev Weiss
2024-03-12 23:58 ` Guenter Roeck
2024-03-13 0:21 ` Zev Weiss
2024-03-18 1:02 ` Ban Feng
2024-03-19 0:35 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALz278ad+c6=BCrmHW9GfC3WkkOyhyvoR0xYxmi=_awUmjhdqw@mail.gmail.com' \
--to=baneric926@gmail.com \
--cc=DELPHINE_CHIU@wiwynn.com \
--cc=billy_tsai@aspeedtech.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kcfeng0@nuvoton.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kwliu@nuvoton.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).