From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Tariq Toukan <tariqt@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5e: Fix uninitialized variable
Date: Tue, 31 Jul 2018 14:47:58 -0700 [thread overview]
Message-ID: <CALzJLG8=TttvWE_tqsqafU=qcV_c67UQYLqQzPwYnXXfX3PokA@mail.gmail.com> (raw)
In-Reply-To: <20180731142157.GA24066@embeddedor.com>
On Tue, Jul 31, 2018 at 7:21 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> There is a potential execution path in which variable *err* is returned
> without being properly initialized previously.
>
> Fix this by initializing variable *err* to 0.
>
> Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")
> Fixes: 0ec13877ce95 ("net/mlx5e: Gather all XDP pre-requisite checks in a single function")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
next prev parent reply other threads:[~2018-07-31 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 14:21 [PATCH] net/mlx5e: Fix uninitialized variable Gustavo A. R. Silva
2018-07-31 14:50 ` Tariq Toukan
2018-07-31 21:47 ` Saeed Mahameed [this message]
2018-08-01 16:38 ` David Miller
2018-08-01 17:19 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALzJLG8=TttvWE_tqsqafU=qcV_c67UQYLqQzPwYnXXfX3PokA@mail.gmail.com' \
--to=saeedm@dev.mellanox.co.il \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).