From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C0CC04AAA for ; Fri, 3 May 2019 18:38:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14F672081C for ; Fri, 3 May 2019 18:38:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="n9XnWJAP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726521AbfECSiE (ORCPT ); Fri, 3 May 2019 14:38:04 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:33364 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbfECSiD (ORCPT ); Fri, 3 May 2019 14:38:03 -0400 Received: by mail-ot1-f67.google.com with SMTP id s11so6205061otp.0 for ; Fri, 03 May 2019 11:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=igK2hkimOLYL0v51jrHSB9BR0OokxEkSsmmhvh8dBYg=; b=n9XnWJAPxfp9OVLqm1MzLP2NbbIHojI5DaFLgmQfXodUJYykUHDHt7PJJSbZzdttra a0PrrohZUmjNCfzfQrFpFfomG0ymsatj7eIJ2NtvJPIlQYH+7j3RhAZzwlKbaXuVSibP E01kIRwlXrTgqsl6j8roOzUqzZdSaC3hCJt58= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=igK2hkimOLYL0v51jrHSB9BR0OokxEkSsmmhvh8dBYg=; b=QtiYHq0KqtxfkyDwP9czlZ+xCxFEfNJZqr/1vmh/kmJnCVHxwFkVUcuLuJcZbjSLwH +roOu+wvC+d5DNAaiK/Pln9NJe7G+7VlauEEDy8CGdT37mae5WvREEf+sj1VXWMgzzLG UiFEga1KruZM70Q1RX6kxiJdjySCQvVhCq5u/UyErjqYcH63QKJytaMyMdbpgAVONkTC wh4QyReP/bcE03Lnj1x1MtM5FS85tAYyOfa2gyjIUmD4H2TrmIF1DrNMRmlTVXjMmtud 4wxp79bCQt7ruDUkj9fOzbbhaxlIp/9ZUILWQrTSCAHOookotWSfw1HT9PtI/6U95vrD xZhQ== X-Gm-Message-State: APjAAAX9nQE/+ql3b5excPJhrAsSctSRCAlmvDrVzZ/4wyZBeZuxt0V/ 4IfgcobjLvbIQF0r8w7saPstecVfGPA5t8nM9E48uQ== X-Google-Smtp-Source: APXvYqyNKoXq7xTo87oybEtZhPUf9Rpiit6ISgOcAchV1sZ83eW0qVB1QqwR5Ii63agVaWpDu6qea9xTTRZWtibKkMw= X-Received: by 2002:a9d:1288:: with SMTP id g8mr8368844otg.28.1556908682674; Fri, 03 May 2019 11:38:02 -0700 (PDT) MIME-Version: 1.0 References: <20181018185616.14768-1-keescook@chromium.org> <20181018185616.14768-3-keescook@chromium.org> In-Reply-To: <20181018185616.14768-3-keescook@chromium.org> From: Douglas Anderson Date: Fri, 3 May 2019 11:37:51 -0700 Message-ID: Subject: Re: [PATCH pstore-next v2 2/4] pstore: Allocate compression during late_initcall() To: Kees Cook , stable@vger.kernel.org Cc: LKML , "Joel Fernandes (Google)" , Sai Prakash Ranjan , Guenter Roeck , Dan Williams , Anton Vorontsov , Colin Cross , Tony Luck Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Oct 18, 2018 at 11:56 AM Kees Cook wrote: > > From: "Joel Fernandes (Google)" > > ramoops's call of pstore_register() was recently moved to run during > late_initcall() because the crypto backend may not have been ready during > postcore_initcall(). This meant early-boot crash dumps were not getting > caught by pstore any more. > > Instead, lets allow calls to pstore_register() earlier, and once crypto > is ready we can initialize the compression. > > Reported-by: Sai Prakash Ranjan > Signed-off-by: Joel Fernandes (Google) > Tested-by: Sai Prakash Ranjan > Fixes: cb3bee0369bc ("pstore: Use crypto compress API") > [kees: trivial rebase] > Signed-off-by: Kees Cook > --- > fs/pstore/platform.c | 10 +++++++++- > fs/pstore/ram.c | 2 +- > 2 files changed, 10 insertions(+), 2 deletions(-) I'd propose that these three patches: 95047b0519c1 pstore: Refactor compression initialization 416031653eb5 pstore: Allocate compression during late_initcall() cb095afd4476 pstore: Centralize init/exit routines Get sent to linux-stable. Specifically I'll mention that 4.19 needs it. IMO the regression of pstore not catching early boot crashes is pretty serious IMO. Thanks! -Doug