From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B0A1CD20 for ; Mon, 26 Feb 2024 10:59:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708945196; cv=none; b=cdbsO6cHmE8B9UcEWZGvkL4raDN0CAtuJf1+aiBljL9ExBw+NshJYSfhmvrMSITkcq1jecAWEuH2aO+jlLERhGxqsR4SUp56jWwQX4KrSvdh44bJJCR/+EJ8tBKnHDb/WTgqSN5teSO0XWC1BU4D1UMCWtC4GyhwWxPWMP8sTYE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708945196; c=relaxed/simple; bh=Gr4SEf1HRZuWiHK525jc8aBUZa59KPy1tNkRmXagChc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=eiFgTZV53LE4iwb/CYnhDol8oxjX2efPpr9UgXWs/Ll0nKTYG8c1Kwz6BBZh8i9M1NYcan8I2hQKebSxwLC9ZVmeEqfCm1Tt7ht0/2wuXQMZb2Ik0pdOoqyy5CJgrXX/uKMJ0OWAQHMviTfeSMENjtaIFQB/fA97zSjeDVuJeMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1Zl/3znj; arc=none smtp.client-ip=209.85.166.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1Zl/3znj" Received: by mail-il1-f172.google.com with SMTP id e9e14a558f8ab-3650ea7f7d3so4949755ab.1 for ; Mon, 26 Feb 2024 02:59:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708945193; x=1709549993; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9HBNX3ZrqYqah+wR2ZXlErwOwwFl2gjzLKDMAIKzAXQ=; b=1Zl/3znj1NiuInaDNmsNiSi8tg/90EYPECXbL9Y1xGrO2QVBptLOwVfjLuA8AM0/xr eK3LNtRs15Th37cUzECuItOgaCjdg/CU5duq0PR77dvF/xeLI5oWG8Snqh+aAw3weY4o NARwRoMz8FvNwR3Luzf7f2/9kpmOkIW4TLQgqjB+5U49Zo2xLdyiraAChsPbjTT1eowD Rj8/zRgpi9zDl6hDo+3OajYdp+bJ7Wd0OVqEwMFIuBtz4lOkjbXyfVNDerRHOgo91Hu1 0HanJryWyu3cJv/uftLN6vgvlgiVnam4Jp/qNQJs5p1CfCceksAL1uxZV7KjqRdI8/9J /htA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708945193; x=1709549993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9HBNX3ZrqYqah+wR2ZXlErwOwwFl2gjzLKDMAIKzAXQ=; b=LDqGc9wv/5gzGr6pDFPnsNDuNDXCdQGBya3qh5o2vC8Ef7oyadsm6WrLrkzxoy/3uu +uviC7T4gC9tDbmqswerLV66mjfSq56YspJxmltxu0cL26PqKgQHyWbWXxYLI0ANBDRg Or9nySov5t2k1nmYMg8OmAaiJcRC0F0ypfoccjtc2E30VB5HeAQvHydumC/76taE05xm jU5NFjtwVOx5N5lAEQz0cmeq7F1OeGyWdiwT8YjLdhB7vl5oxR5e1L6/K/BtyFuTGvY9 WI0oZNhH66VTgRZ37VnNLL8Kvyq4fyw4iTa8HXDYMrHNImpnHPOntWQWVLe0poNgizHV SLYQ== X-Forwarded-Encrypted: i=1; AJvYcCUhHH88p+nCpNpN2MH7raZ+DeO05oFjCh/LBcsVWLHUX6eDyOkAX2ekkKKp7XEaUmMOye9N2UVCaujC5Ww6zVUNXunIFJcESGGmWS5S X-Gm-Message-State: AOJu0YwY/eGfGOPACVae1uYcvCKCObBT7XwF5uXiAxbcpqRAOlIrpQSk w/4AmceEdTwV9CadK1ZsRe4OIQP9jc9gvZFlCqGC7Rvulxm7mQsiNuiWAOIiX1RQPVQDGM8gy1E crn7RpC+RFuKQHjlupk/0zSmuldXBoArR8L4X X-Google-Smtp-Source: AGHT+IGPWqkD9tP0s2DR5YozsFzpUTq3DqbX3426VLgw1SJtB5jrdYmWVGilTio3nCJ+QrJqqp33UcQOcDrbUDfAfdM= X-Received: by 2002:a05:6e02:348e:b0:363:c1ce:1a6 with SMTP id bp14-20020a056e02348e00b00363c1ce01a6mr8258336ilb.13.1708945193051; Mon, 26 Feb 2024 02:59:53 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221160215.484151-1-panikiel@google.com> <20240221160215.484151-9-panikiel@google.com> <13aeb2ff-72f4-49d9-b65e-ddc31569a936@linaro.org> In-Reply-To: <13aeb2ff-72f4-49d9-b65e-ddc31569a936@linaro.org> From: =?UTF-8?Q?Pawe=C5=82_Anikiel?= Date: Mon, 26 Feb 2024 11:59:42 +0100 Message-ID: Subject: Re: [PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP To: Krzysztof Kozlowski Cc: airlied@gmail.com, akpm@linux-foundation.org, conor+dt@kernel.org, daniel@ffwll.ch, dinguyen@kernel.org, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, maarten.lankhorst@linux.intel.com, mchehab@kernel.org, mripard@kernel.org, robh+dt@kernel.org, tzimmermann@suse.de, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, chromeos-krk-upstreaming@google.com, ribalda@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 26, 2024 at 10:13=E2=80=AFAM Krzysztof Kozlowski wrote: > > On 21/02/2024 17:02, Pawe=C5=82 Anikiel wrote: > > The Intel Displayport RX IP is a part of the DisplayPort Intel FPGA IP > > Core. It implements a DisplayPort 1.4 receiver capable of HBR3 video > > capture and Multi-Stream Transport. The user guide can be found here: > > > > https://www.intel.com/programmable/technical-pdfs/683273.pdf > > > > Signed-off-by: Pawe=C5=82 Anikiel > > --- > > .../devicetree/bindings/media/intel,dprx.yaml | 160 ++++++++++++++++++ > > 1 file changed, 160 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/intel,dprx.= yaml > > > > diff --git a/Documentation/devicetree/bindings/media/intel,dprx.yaml b/= Documentation/devicetree/bindings/media/intel,dprx.yaml > > new file mode 100644 > > index 000000000000..31025f2d5dcd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/intel,dprx.yaml > > @@ -0,0 +1,160 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/intel,dprx.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Intel DisplayPort RX IP > > + > > +maintainers: > > + - Pawe=C5=82 Anikiel > > + > > +description: | > > + The Intel Displayport RX IP is a part of the DisplayPort Intel FPGA = IP > > + Core. It implements a DisplayPort 1.4 receiver capable of HBR3 video > > + capture and Multi-Stream Transport. > > + > > + The IP features a large number of configuration parameters, found at= : > > + https://www.intel.com/content/www/us/en/docs/programmable/683273/23-= 3-20-0-1/sink-parameters.html > > + > > + The following parameters have to be enabled: > > + - Support DisplayPort sink > > + - Enable GPU control > > + The following parameters' values have to be set in the devicetree: > > + - RX maximum link rate > > + - Maximum lane count > > + - Support MST > > + - Max stream count (only if Support MST is enabled) > > + > > +properties: > > + compatible: > > + const: intel,dprx-20.0.1 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + intel,max-link-rate: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Max link rate configuration parameter > > Please do not duplicate property name in description. It's useless. > Instead explain what is this responsible for. > > Why max-link-rate would differ for the same dprx-20.0.1? And why > standard properties cannot be used? > > Same for all questions below. These four properties are the IP configuration parameters mentioned in the device description. When generating the IP core you can set these parameters, which could make them differ for the same dprx-20.0.1. They are documented in the user guide, for which I also put a link in the description. Is that enough? Or should I also document these parameters here? > > > + > > + intel,max-lane-count: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Max lane count configuration parameter > > + > > + intel,multi-stream-support: > > + type: boolean > > + description: Multi-Stream Transport support configuration paramete= r > > + > > + intel,max-stream-count: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: Max stream count configuration parameter > > + > > + port: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: SST main link > > I don't understand why you have both port and ports. Shouldn't this be > under ports? I put both so that you can use the shorter port property when the device only has one port (i.e. no MST support). It would work fine without it. If you think that's unnecessary, I can remove it (and use the ports property even if there is only one).