From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 806C31CFB4 for ; Mon, 26 Feb 2024 11:09:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708945793; cv=none; b=rxNe+4K5QFRuck9JQ9jo5wqLrXhMBTvX/bR6x0xYB/nTsYSKHFgimP26S8GxBw1SsPWAetpElXO4eTtgH5fGn9k4je2ZlqpbgeTvlc9hMjUw9ZIkkwm8LdkLJe9z03DdbGyocF9ZBWMmjPccYRZkuEf0vPJsLdeC9ovR59fwp+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708945793; c=relaxed/simple; bh=+jLqiY6cbZkUaeKfyLrEDAjpX1juOggyIGmJMdgRqLw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=UKMno71G92L0pEaiTmwQkpz+pwiN+g74EiUZjovOtsi8PtyVr4SjTJwT+rcVBRuKHPkfFoD+fLldXPYvR9fT0qVweP1mZYqidZ4DDUxxOS3KDVNt9cbBIivFIW4a/DGmtGIu9nO/IEQUT+fWSs8oSwTKqy5ea49yu8hmLmbkJcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=a2XB+967; arc=none smtp.client-ip=209.85.166.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="a2XB+967" Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-7c794deb6cdso139294239f.0 for ; Mon, 26 Feb 2024 03:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708945790; x=1709550590; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JXLJhA1S2e5W/9PS2kr0cO7SXhI9yiOHp+T3ajmhreE=; b=a2XB+967CIeQo5ZJMtHJc0wglP2aueVO3UgSq70jxjug7SRjyemB3PM1Pm4fURQmlI Pog68vVPTzTL7geTiWU93hHLzdfkGlDQ1KMLsy68a4vq2mKCtbWub6oxmTQVBcYqLq5B bzwm5hW1uW8QBJCLzHkGa3VqBc9/Z/SVWGin1jazTdt3p/YDf5hrTMM7JGgFHURU943c qSPC6WYOB5ZHZ5un8c6/0gvtaw8b/QZ+KWMG7ru4MOyMVb9pxHalXYfWKaSeV4iK5auw tcw5Ez4L0cVCLu0Quwvbq92q7oh7z87M078T241mOlK/ESkHQZKPjzKkO7N41sF1Go0x fOqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708945790; x=1709550590; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JXLJhA1S2e5W/9PS2kr0cO7SXhI9yiOHp+T3ajmhreE=; b=S+Gzx+fLGDK4BF0u92+IxQ+YQWgempZunvZnHKo/hQXleCcWVbSN8lihFnEUXSZXMs gSiLxgtfo0NiogUqPYaGYV+8hm0MUoalE4vbqE8GzoFEwUz6Y9J0GeVNbgkf73mlHg8k YXCtc7TBqJNojjFUT54Jptgsnanjnc5BG00r6xTMS2naUZpI/PuW2UpIVF4P7R7JtP4p BRDVvf1rAQ12lrhtJQnCcizm8gqVcUaxGEKgfcpglMXr5VkSKkcJGE5kodwrPISiHYWy HbRGWfth8fk9qDYbMep78J6snInVnUpOVFex+fFeBhhIgS1XWWH841K/nSxivkFm1cRp bMEw== X-Forwarded-Encrypted: i=1; AJvYcCUfjYb3WXDnZg/6eIJIIgVRR0Ck9Y2NZBBFlmz7VzxWCKCvZ6ksZDqnbRHp4dRsF/6NVOH9/hNbQfzgSzu/4GNg061VJqYNkrlyAexk X-Gm-Message-State: AOJu0YzcgSZ/YQf11yoy/4RiXuL+eLHxQ9qA8m3bMvcGIUKIllk6+cma lK0bhdM9TIJJHcow+N1FsPk52Uzh1rdbFh8jYmKpbrIBpg5u7ZpP6WPtxdM7yZpr5xa6VO4dUD+ 43ij5z107dFrbIe1bwgKRafFDuSoEylWyx4L6 X-Google-Smtp-Source: AGHT+IEwEjd31elUaYKxIxM1mh70wep688OMqmuk7WudxZLnasYmVXOgCmS1ONaiIwRiUMQlImGVZaLvPKNgX1VcCmA= X-Received: by 2002:a05:6602:2765:b0:7c7:9944:cc8a with SMTP id l5-20020a056602276500b007c79944cc8amr8677661ioe.5.1708945790588; Mon, 26 Feb 2024 03:09:50 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221160215.484151-1-panikiel@google.com> <20240221160215.484151-10-panikiel@google.com> <310cefcb-a4d5-4f4f-a482-ba2ff08a57f6@linaro.org> In-Reply-To: <310cefcb-a4d5-4f4f-a482-ba2ff08a57f6@linaro.org> From: =?UTF-8?Q?Pawe=C5=82_Anikiel?= Date: Mon, 26 Feb 2024 12:09:39 +0100 Message-ID: Subject: Re: [PATCH v2 9/9] ARM: dts: chameleonv3: Add video device nodes To: Krzysztof Kozlowski Cc: airlied@gmail.com, akpm@linux-foundation.org, conor+dt@kernel.org, daniel@ffwll.ch, dinguyen@kernel.org, hverkuil-cisco@xs4all.nl, krzysztof.kozlowski+dt@linaro.org, maarten.lankhorst@linux.intel.com, mchehab@kernel.org, mripard@kernel.org, robh+dt@kernel.org, tzimmermann@suse.de, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, chromeos-krk-upstreaming@google.com, ribalda@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 26, 2024 at 10:15=E2=80=AFAM Krzysztof Kozlowski wrote: > > On 21/02/2024 17:02, Pawe=C5=82 Anikiel wrote: > > Add device nodes for the video system present on the Chameleon v3. > > It consists of six framebuffers and two Intel Displayport receivers. > > > > Signed-off-by: Pawe=C5=82 Anikiel > > --- > > ... > > > + dprx_sst: dp-receiver@c0064000 { > > + compatible =3D "intel,dprx-20.0.1"; > > + reg =3D <0xc0064000 0x800>; > > + interrupt-parent =3D <&dprx_sst_irq>; > > + interrupts =3D <0 IRQ_TYPE_EDGE_RISING>; > > + intel,max-link-rate =3D <0x1e>; > > Rate is not in hex! Rate is in Hz, at least usually... > > Fix your bindings... This is the DisplayPort link rate, for which the allowed values are 8.1 Gbps, 5.4 Gbps, 2.7 Gbps, or 1.62 Gbps. The standard way to encode them (used in the DisplayPort DPCD registers and this device's configuration) is by multiples of 0.27Gbps. This value (AFAIK) is usually represented in hex, so 8.1Gbps would be 0x1e.