linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sven van Ashbrook <svenva@chromium.org>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: Rajat Jain <rajatja@google.com>,
	Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
	"rrangel@chromium.org" <rrangel@chromium.org>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	Rafael J Wysocki <rjw@rjwysocki.net>,
	David E Box <david.e.box@intel.com>,
	Mark Gross <markgross@kernel.org>,
	"swboyd@chromium.org" <swboyd@chromium.org>
Subject: Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
Date: Tue, 1 Nov 2022 13:24:10 -0400	[thread overview]
Message-ID: <CAM7w-FUTHEAis-F3bDWSsxzQdT-koD-UO54ee9NzbBpKiQhPzQ@mail.gmail.com> (raw)
In-Reply-To: <29e7c8f5-0784-6501-e3fb-f2ab33d3f438@amd.com>

On Mon, Oct 31, 2022 at 4:55 PM Limonciello, Mario
<mario.limonciello@amd.com> wrote:
>
> I just spun together an RFC series for this idea and while doing it I
> had the same realization.  So I left the warning messages in place for
> both drivers.
>
> You can take a look at the series here:
>
> https://lore.kernel.org/platform-driver-x86/20221031204320.22464-1-mario.limonciello@amd.com/T/#m6c7db55c98b8a3ce8c48d451fc01c1d9b0df37fb
>

We've had some internal discussions within ChromeOS intel big core,
and we believe this is a worthwhile effort, and we are supportive, as
long as our current S0ix fail detection will not break for the
foreseeable future, i.e. as long as the warning message and register
dump stays in place. Which is the case for your RFC.

+swboyd@chromium.org who expressed interest in doing something similar for ARM.

  reply	other threads:[~2022-11-01 17:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 15:19 [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN() Sven van Ashbrook
2022-10-27 15:40 ` Hans de Goede
2022-10-27 15:47   ` Limonciello, Mario
2022-10-27 15:51     ` Sven van Ashbrook
     [not found]       ` <CAE2upjS6qRGRcuVYuAB5DMf66A7VcfCKKYEkpsr1My7RnKDFtQ@mail.gmail.com>
2022-10-29  4:11         ` Sven van Ashbrook
2022-10-31 19:39           ` Limonciello, Mario
2022-10-31 20:15             ` Hans de Goede
2022-10-31 20:20               ` Sven van Ashbrook
     [not found]             ` <CACK8Z6E7=xt118d47FTpmgKHgUBgH48FQzTi5iL90C3MjHb-3Q@mail.gmail.com>
2022-10-31 20:55               ` Limonciello, Mario
2022-11-01 17:24                 ` Sven van Ashbrook [this message]
2022-11-01 20:30                   ` David E. Box
2022-11-01  1:38             ` Sven van Ashbrook
2022-11-01  1:58               ` Mario Limonciello
2022-11-01 13:50                 ` Sven van Ashbrook
2022-10-27 16:37   ` David E. Box

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM7w-FUTHEAis-F3bDWSsxzQdT-koD-UO54ee9NzbBpKiQhPzQ@mail.gmail.com \
    --to=svenva@chromium.org \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=david.e.box@intel.com \
    --cc=hdegoede@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rajatja@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=rrangel@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).