From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A32EC4332D for ; Thu, 19 Mar 2020 16:30:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4F0D2072C for ; Thu, 19 Mar 2020 16:29:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KOuV7mgf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728073AbgCSQ36 (ORCPT ); Thu, 19 Mar 2020 12:29:58 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:41825 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727222AbgCSQ36 (ORCPT ); Thu, 19 Mar 2020 12:29:58 -0400 Received: by mail-wr1-f67.google.com with SMTP id h9so3861034wrc.8; Thu, 19 Mar 2020 09:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dUjkv/1kdxAPc8FvGXSwJvqVlpdlMdd7sScfjZuLtXU=; b=KOuV7mgfPxa5BS7QM1EmpVKHl+utg3R1NuD+eghOx5tCnKmaPuHRVXjvk7ETGC7+IH pWrSjx5ZFJvHZf44R+FxNhYQeCT5QW+rQ4hPqVWEYiBB13CMSgH3RlgZseLHIeM1bG2l 1obkvh3OhbRF8Mk7ezjkpUNYtcONq6/QkjHI3j/LQhbXuFNPvr+ozb6qq6d7/OoORL65 flbWD6QSUtjzo8zmFjsywEco3MosobFFfwQQ/QEi9RDyxPZkUizLDlfsgEoBkxyn28FZ T+rxTDp7rTvNrrva4WA9EN5sBtyDWyGY0mu7exVkkA3+j062YpuZVJfNb//An6i8J7Dg Q10w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dUjkv/1kdxAPc8FvGXSwJvqVlpdlMdd7sScfjZuLtXU=; b=mb3uXV8MHRlmY9fKmY3YGk3cp92PK7ShiWGBBnZzAb5E6VpUW5JaBD68jyvPRFgP5G HikdmtNbV4a0kWuZf8QVGbJqStnVnD23UjePVC+bFqLzOgj9AHm1UWXTR/Rmc/tNeHpz u6TCqIIleuOpEoWx31JKK0vE2cEuY/8KHm6pxNx+ItASME3UBNo8Ii4Pk7BcR/NR5J9m QuKWQvnH7AFqucjW507fi8U+HtRarAZxi2rvIeduiP24aMmn+xn4J5qSGD6ubR1e6apW Z0H2AhZRTFoo8AARps2lNQIZdZPW1eSmG0fDIdMK+6OwUrRwPmGyd+G9AM4BDpZ8z7TC 6caQ== X-Gm-Message-State: ANhLgQ0ClMCYQG+YuoioJnu0IvdwV4gpKeR3v2oYMZrJ1lUJhlLXVaqX tLUTjP4ZK8nu1PcwaVjUw0HJd0o9poKprYDSV3o= X-Google-Smtp-Source: ADFU+vvErlZUbjGMAWaIpw3qbv9beB1N3R3kHK0bJH6Z7AaZmsMVBHwa/EoutXRVLGkwpqQKNDNT9RewnuF5ANVC4ms= X-Received: by 2002:a5d:6146:: with SMTP id y6mr5298504wrt.107.1584635395363; Thu, 19 Mar 2020 09:29:55 -0700 (PDT) MIME-Version: 1.0 References: <20200319131221.14044-1-david@redhat.com> <20200319131221.14044-3-david@redhat.com> In-Reply-To: <20200319131221.14044-3-david@redhat.com> From: Pankaj Gupta Date: Thu, 19 Mar 2020 17:29:44 +0100 Message-ID: Subject: Re: [PATCH v3 2/8] drivers/base/memory: map MMOP_OFFLINE to 0 To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, Wei Yang , Michal Hocko , Greg Kroah-Hartman , Andrew Morton , Michal Hocko , Oscar Salvador , "Rafael J. Wysocki" , Baoquan He Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Historically, we used the value -1. Just treat 0 as the special > case now. Clarify a comment (which was wrong, when we come via > device_online() the first time, the online_type would have been 0 / > MEM_ONLINE). The default is now always MMOP_OFFLINE. This removes the > last user of the manual "-1", which didn't use the enum value. > > This is a preparation to use the online_type as an array index. > > Reviewed-by: Wei Yang > Acked-by: Michal Hocko > Cc: Greg Kroah-Hartman > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: "Rafael J. Wysocki" > Cc: Baoquan He > Cc: Wei Yang > Signed-off-by: David Hildenbrand > --- > drivers/base/memory.c | 11 ++++------- > include/linux/memory_hotplug.h | 2 +- > 2 files changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > index 8c5ce42c0fc3..e7e77cafef80 100644 > --- a/drivers/base/memory.c > +++ b/drivers/base/memory.c > @@ -211,17 +211,14 @@ static int memory_subsys_online(struct device *dev) > return 0; > > /* > - * If we are called from state_store(), online_type will be > - * set >= 0 Otherwise we were called from the device online > - * attribute and need to set the online_type. > + * When called via device_online() without configuring the online_type, > + * we want to default to MMOP_ONLINE. > */ > - if (mem->online_type < 0) > + if (mem->online_type == MMOP_OFFLINE) > mem->online_type = MMOP_ONLINE; > > ret = memory_block_change_state(mem, MEM_ONLINE, MEM_OFFLINE); > - > - /* clear online_type */ > - mem->online_type = -1; > + mem->online_type = MMOP_OFFLINE; > > return ret; > } > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 3aaf00db224c..76f3c617a8ab 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -48,7 +48,7 @@ enum { > /* Types for control the zone type of onlined and offlined memory */ > enum { > /* Offline the memory. */ > - MMOP_OFFLINE = -1, > + MMOP_OFFLINE = 0, > /* Online the memory. Zone depends, see default_zone_for_pfn(). */ > MMOP_ONLINE, > /* Online the memory to ZONE_NORMAL. */ > -- > 2.24.1 Looks good to me. Acked-by: Pankaj Gupta > >