From: Namhyung Kim <namhyung@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event
Date: Fri, 30 Aug 2019 12:56:02 +0900 [thread overview]
Message-ID: <CAM9d7cgFAc7WyZY4n82YLU=5yAifrVqoCtHh2iE-aLKx=uC4=w@mail.gmail.com> (raw)
In-Reply-To: <20190828144830.GQ2263813@devbig004.ftw2.facebook.com>
Hi Tejun,
On Wed, Aug 28, 2019 at 11:48 PM Tejun Heo <tj@kernel.org> wrote:
>
> Hello, Namhyung.
>
> On Wed, Aug 28, 2019 at 04:31:22PM +0900, Namhyung Kim wrote:
> > + * struct {
> > + * struct perf_event_header header;
> > + * u64 ino;
> > + * u64 path_len;
> > + * char path[];
>
> ino and path aren't great identifers for cgroups because both can get
> recycled pretty quickly. Can you please take a look at
> KERNFS_ROOT_SUPPORT_EXPORTOP? That's the fhandle that cgroup uses,
> currently the standard ino+gen which isn't ideal but good enough.
> Another benefit is that the path can also be resolved efficiently from
> userspace given the handle.
Thanks for the info, I'll take a look at it.
Namhyung
next prev parent reply other threads:[~2019-08-30 3:56 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 7:31 [PATCHSET 0/9] perf: Improve cgroup profiling (v1) Namhyung Kim
2019-08-28 7:31 ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Namhyung Kim
2019-08-28 9:44 ` Peter Zijlstra
2019-08-28 9:44 ` Peter Zijlstra
2019-08-28 13:13 ` Arnaldo Carvalho de Melo
2019-08-30 3:46 ` Namhyung Kim
2019-08-30 7:34 ` Peter Zijlstra
2019-08-30 22:49 ` Namhyung Kim
2019-08-30 23:52 ` Stephane Eranian
2019-08-28 14:48 ` Tejun Heo
2019-08-30 3:56 ` Namhyung Kim [this message]
2019-08-28 7:31 ` [PATCH 2/9] perf/core: Add PERF_SAMPLE_CGROUP feature Namhyung Kim
2019-08-28 14:49 ` Tejun Heo
2019-08-31 3:03 ` Namhyung Kim
2019-08-31 4:58 ` Tejun Heo
2019-09-03 2:13 ` Namhyung Kim
2019-09-05 16:56 ` Tejun Heo
2019-09-08 13:28 ` Namhyung Kim
2019-09-14 14:02 ` Song Liu
2019-09-16 15:23 ` Tejun Heo
2019-09-19 6:42 ` Song Liu
2019-09-20 8:47 ` Namhyung Kim
2019-09-20 16:13 ` Song Liu
2019-09-20 21:04 ` Tejun Heo
2019-10-02 6:28 ` Namhyung Kim
2019-10-07 14:16 ` Tejun Heo
2019-08-28 7:31 ` [PATCH 3/9] perf tools: Basic support for CGROUP event Namhyung Kim
2019-08-30 12:55 ` Arnaldo Carvalho de Melo
2019-08-30 22:51 ` Namhyung Kim
2019-08-28 7:31 ` [PATCH 4/9] perf tools: Maintain cgroup hierarchy Namhyung Kim
2019-08-28 7:31 ` [PATCH 5/9] perf report: Add 'cgroup' sort key Namhyung Kim
2019-08-28 7:31 ` [PATCH 6/9] perf record: Support synthesizing cgroup events Namhyung Kim
2019-08-28 7:31 ` [PATCH 7/9] perf record: Add --all-cgroups option Namhyung Kim
2019-08-28 7:31 ` [PATCH 8/9] perf top: " Namhyung Kim
2019-08-28 7:31 ` [PATCH 9/9] perf script: Add --show-cgroup-events option Namhyung Kim
2019-12-20 4:32 [PATCHSET 0/9] perf: Improve cgroup profiling (v2) Namhyung Kim
2019-12-20 4:32 ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Namhyung Kim
2019-12-20 9:33 ` Peter Zijlstra
2019-12-20 11:28 ` Namhyung Kim
2019-12-20 11:50 ` Namhyung Kim
2019-12-20 15:16 ` Tejun Heo
2019-12-21 8:49 ` Namhyung Kim
2019-12-23 6:07 [PATCHSET 0/9] perf: Improve cgroup profiling (v3) Namhyung Kim
2019-12-23 6:07 ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Namhyung Kim
2020-01-07 12:51 ` Peter Zijlstra
2020-01-07 13:46 ` Namhyung Kim
2020-01-07 13:34 [PATCHSET 0/9] perf: Improve cgroup profiling (v4) Namhyung Kim
2020-01-07 13:34 ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Namhyung Kim
2020-03-25 12:45 [PATCHSET 0/9] perf: Improve cgroup profiling (v6) Namhyung Kim
2020-03-25 12:45 ` [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7cgFAc7WyZY4n82YLU=5yAifrVqoCtHh2iE-aLKx=uC4=w@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=hannes@cmpxchg.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).