From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5712C433E2 for ; Thu, 17 Sep 2020 01:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 852022075E for ; Thu, 17 Sep 2020 01:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600306317; bh=YyJJXIbPRhh/Pn+b8dFdtZHL58bRuStr9LcNmmjkeek=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=wvcP2vu8DY7Mu6dQH/+eqj+Bf+Uup/SSl7pyWMkPGASQKhR5dM2ToZMj6ZkHRoeHN kTkHWdQxMz+qrMDr/jc55JJByOK8ygMxjZcpsMyyQoX3R5W7+9fnUVgeomQzwwN9F3 0+CU4F6GrlGRfMVD5SCW0+ZvROFy6d3NTpKAExUY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726153AbgIQBb4 (ORCPT ); Wed, 16 Sep 2020 21:31:56 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37470 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725858AbgIQBbs (ORCPT ); Wed, 16 Sep 2020 21:31:48 -0400 Received: by mail-wm1-f65.google.com with SMTP id a9so374084wmm.2 for ; Wed, 16 Sep 2020 18:31:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SXoIbXzgcc+a9Nuqz6QLmgpLC7jamvauDUiy+563tNg=; b=MnZCM9nXlIJPbwM23uSi/uy8fw3GDI9vWMUGxTNmSJxvkLGPvL+P6CX5lcpT8oU+b5 ZIXbmCLDf/+YZKIdHpGhk/Da24syh685cuaMYxARYBFRaHnoodN4uK3MWdD7fUaox1NU jhYAP3eZwguDfadWIJwmyxjX8UwMtAAaZ1L9sdLoaQKXHLSL7EXgbBY5HF10Izh2dFLi QOMwWmFz2aLUPfX7fyf8oSZNHKnoMDcFjILiocxjmAkfM3Whc8X5FugJsxpCq3+yQzF3 RTEQII/XrXjkIcLeJOBQCiljDJbhjIBjL5589DT5fdVCJ2Z6ZAQKyBOyUU7wr6ttJ6hQ wa5Q== X-Gm-Message-State: AOAM532kHnjA+aRmPPaHZDl/aczYh9gwqyf109Mn3O/jG1ukd0CQmpAS iNcJ7an5fh+zvKnUrIXhoXvz+z5qnWjEKwQFtb94lRqi X-Google-Smtp-Source: ABdhPJwvY7a6rCKNqCxefomED/UrY21ZIS6bqz9lRPm4t3fRokuQP0KJXf72VA2vm2o5rPoobo67t6elv8SKTD2S3Cw= X-Received: by 2002:a7b:c404:: with SMTP id k4mr7298553wmi.168.1600306306736; Wed, 16 Sep 2020 18:31:46 -0700 (PDT) MIME-Version: 1.0 References: <20200914141859.332459-1-namhyung@kernel.org> <20200914141859.332459-3-namhyung@kernel.org> <20200915100533.GC2171499@krava> In-Reply-To: <20200915100533.GC2171499@krava> From: Namhyung Kim Date: Thu, 17 Sep 2020 10:31:35 +0900 Message-ID: Subject: Re: [PATCH 3/3] perf inject: Do not load map/dso when injecting build-id To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Mark Rutland , Alexander Shishkin , Stephane Eranian , LKML , Ian Rogers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 7:05 PM Jiri Olsa wrote: > > On Mon, Sep 14, 2020 at 11:18:59PM +0900, Namhyung Kim wrote: > > @@ -478,19 +479,8 @@ static int perf_event__inject_buildid(struct perf_tool *tool, > > if (thread__find_map(thread, sample->cpumode, sample->ip, &al)) { > > if (!al.map->dso->hit) { > > al.map->dso->hit = 1; > > - if (map__load(al.map) >= 0) { > > nice, that might do some nice speedup, did you see any? I've checked it but the speed up was tiny on my machine. I guess it's because the machine was idle and had everything in memory. But I also found some more points to improve. Will share the result in the next spin. Thanks Namhyung