From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbaCAB1s (ORCPT ); Fri, 28 Feb 2014 20:27:48 -0500 Received: from mail-oa0-f50.google.com ([209.85.219.50]:41132 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbaCAB1r (ORCPT ); Fri, 28 Feb 2014 20:27:47 -0500 MIME-Version: 1.0 In-Reply-To: <20140301010737.GY22728@two.firstfloor.org> References: <1393609388-40489-1-git-send-email-dzickus@redhat.com> <1393609388-40489-12-git-send-email-dzickus@redhat.com> <87ppm7aws9.fsf@tassilo.jf.intel.com> <20140228194422.GL25953@redhat.com> <20140301010737.GY22728@two.firstfloor.org> From: Namhyung Kim Date: Sat, 1 Mar 2014 01:27:27 +0000 X-Google-Sender-Auth: jizX5Xy-lUuVA-l2NzzCFSXbdos Message-ID: Subject: Re: [PATCH 11/19] perf, c2c: Add in sort on physid To: Andi Kleen Cc: Don Zickus , Arnaldo Melo , LKML , Jiri Olsa , jmario@redhat.com, fowles@inreach.com, Stephane Eranian Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andi, On Sat, Mar 1, 2014 at 1:07 AM, Andi Kleen wrote: >> I don't think I understand the problem enough to know what to fix. I just >> copied this piece of code from builtin-report.c and things seemed to work. >> >> Mind giving me some details and I can look at fixing it. :-) > > sort.c even though has all these sort keys only sorts by period. > It should instead sort by all the specified keys in order instead. > > Namhyung looked at it at some point. Yes, I'm working on it now, but I only have a little time. Hopefully I can send a rfc version next week.. Thanks, Namhyung